All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrice Chotard <patrice.chotard@sfr.fr>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Patrice Chotard <patricechotard@free.fr>,
	Antti Palosaari <crope@iki.fi>
Subject: Re: [PATCH] ngene: fix commit 36a495a336c3fbbb2f4eeed2a94ab6d5be19d186
Date: Sat, 05 Jan 2013 10:39:21 +0100	[thread overview]
Message-ID: <50E7F4C9.6050607@sfr.fr> (raw)
In-Reply-To: <1357358802-17296-1-git-send-email-mchehab@redhat.com>

Hi Mauro,

Yes, i confirm that without this patch, tuner_attach_dtt7520x() callback
was never called, so no tuning was possible.

Patrice

Le 05/01/2013 05:06, Mauro Carvalho Chehab a écrit :
> The above commit were applied only partially; it broke tuner and
> demod attach, but the part that added it to ngene_info was missing.
> 
> Not sure what happened there, but, without this patch, a regression
> would be happening.
> 
> Also, gcc complains about a defined but not used symbol.
> 
> So, apply manually the missing part.
> 
> Cc: Patrice Chotard <patricechotard@free.fr>
> Cc: Antti Palosaari <crope@iki.fi>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
>  drivers/media/pci/ngene/ngene-cards.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/ngene/ngene-cards.c b/drivers/media/pci/ngene/ngene-cards.c
> index 2a4895b..82318d1 100644
> --- a/drivers/media/pci/ngene/ngene-cards.c
> +++ b/drivers/media/pci/ngene/ngene-cards.c
> @@ -732,6 +732,7 @@ static struct ngene_info ngene_info_terratec = {
>  	.name           = "Terratec Integra/Cinergy2400i Dual DVB-T",
>  	.io_type        = {NGENE_IO_TSIN, NGENE_IO_TSIN},
>  	.demod_attach   = {demod_attach_drxd, demod_attach_drxd},
> +	.tuner_attach	= {tuner_attach_dtt7520x, tuner_attach_dtt7520x},
>  	.fe_config      = {&fe_terratec_dvbt_0, &fe_terratec_dvbt_1},
>  	.i2c_access     = 1,
>  };
> 

  reply	other threads:[~2013-01-05  9:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-05  4:06 [PATCH] ngene: fix commit 36a495a336c3fbbb2f4eeed2a94ab6d5be19d186 Mauro Carvalho Chehab
2013-01-05  9:39 ` Patrice Chotard [this message]
2013-01-05 13:30   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E7F4C9.6050607@sfr.fr \
    --to=patrice.chotard@sfr.fr \
    --cc=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=patricechotard@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.