From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] tools: imximage: Load a size that is multiple of 512
Date: Sat, 05 Jan 2013 18:10:42 +0100 [thread overview]
Message-ID: <50E85E92.80501@denx.de> (raw)
In-Reply-To: <1357237473-1401-1-git-send-email-fabio.estevam@freescale.com>
On 03/01/2013 19:24, Fabio Estevam wrote:
> In order to mx53 ROM to properly load the U-boot image, its header size should
> be multiple of 512 bytes.
>
> This issue was observed with gcc 4.6.2/4.7.3, which caused data aborts:
>
> U-Boot 2013.01-rc2-00172-gf8cfcf1-dirty (Dec 26 2012 - 13:13:28)
>
> Board: MX53 LOCO
> I2C: ready
> DRAM: 1 GiB
> MMC: FSL_SDHC: 0, FSL_SDHC: 1
> In: serial
> Out: serial
> Err: serial
> CPU: Freescale i.MX53 family rev2.1 at 1000 MHz
> Reset cause: WDOG
> Net: FEC
> Warning: FEC using MAC address from net device
>
> Hit any key to stop autoboot: 0
> data abort
>
> MAYBE you should read doc/README.arm-unaligned-accesses
>
> pc : [<aff72220>] lr : [<aff721fc>]
> sp : af565e20 ip : af566918 fp : 00000000
> r10: 00000003 r9 : affabb5b r8 : af565f58
> r7 : 00000000 r6 : 36747fff r5 : af5668e8 r4 : 36747fff
> r3 : af5668ec r2 : af5668eb r1 : 00000000 r0 : af5668e8
> Flags: NzcV IRQs off FIQs off Mode SVC_32
> Resetting CPU ...
>
> resetting ...
>
> ,and this patch fixes it.
>
> Also, even though the ROUND macro is already defined in common.h,
> the reason for redefining it in image.h is explained by Stefano Babic:
>
> "I will remark a previous comment - even if including common.h seems a
> good idea to avoid duplications, it makes tools like mkimage to depend
> on the selected board, because <board>_config must run. Even if this is
> not a problem for us u-boot developers, it becomes an issue when these
> tools are included in distros (like u-boot-tools in Ubuntu) and cannot
> be packaged."
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2013-01-05 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 18:24 [U-Boot] [PATCH v2] tools: imximage: Load a size that is multiple of 512 Fabio Estevam
2013-01-04 6:20 ` Dirk Behme
2013-01-04 9:03 ` Stefano Babic
2013-01-05 0:08 ` Fabio Estevam
2013-01-05 0:16 ` Fabio Estevam
2013-01-05 17:10 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E85E92.80501@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.