From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TruZ7-0005RF-8L for qemu-devel@nongnu.org; Sun, 06 Jan 2013 13:03:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TruZ6-0003Oq-4s for qemu-devel@nongnu.org; Sun, 06 Jan 2013 13:03:21 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54553 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TruZ5-0003Ol-Uh for qemu-devel@nongnu.org; Sun, 06 Jan 2013 13:03:20 -0500 Message-ID: <50E9BC62.6000509@suse.de> Date: Sun, 06 Jan 2013 19:03:14 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1357287364-24921-1-git-send-email-kraxel@redhat.com> <1357287364-24921-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1357287364-24921-2-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/4] switch debugcon to memory api List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Anthony Liguori Am 04.01.2013 09:16, schrieb Gerd Hoffmann: > Also some QOM glue while being at it. >=20 > Signed-off-by: Gerd Hoffmann > --- > hw/debugcon.c | 31 ++++++++++++++++++++++++------- > 1 files changed, 24 insertions(+), 7 deletions(-) >=20 > diff --git a/hw/debugcon.c b/hw/debugcon.c > index 14f83f1..e8a855e 100644 > --- a/hw/debugcon.c > +++ b/hw/debugcon.c > @@ -29,20 +29,27 @@ > #include "isa.h" > #include "pc.h" > =20 > +#define TYPE_ISA_DEBUGCON_DEVICE "isa-debugcon" > +#define ISA_DEBUGCON_DEVICE(obj) \ > + OBJECT_CHECK(ISADebugconState, (obj), TYPE_ISA_DEBUGCON_DEVICE) Note that my previous QOM'ification RFC used the more verbose [TYPE_]ISA_DEBUG_CONSOLE to avoid the "debugcon" abbreviation. Care to cleanup? Otherwise looks good, thanks, and would've got a Reviewed-by had you not rushed to send a PULL. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg