From: Jens Axboe <axboe@kernel.dk>
To: majianpeng <majianpeng@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Remove judgement for rq_mergeable(rq) in func elv_rqhash_find.
Date: Mon, 07 Jan 2013 08:54:34 +0100 [thread overview]
Message-ID: <50EA7F3A.2010601@kernel.dk> (raw)
In-Reply-To: <201301071308168882920@gmail.com>
On 2013-01-07 06:08, majianpeng wrote:
> Because only mergeable rq can add rqhash.So it does not make sense to
> judge rq_mergeable(rq) in func elv_rqhash_find.
It does make sense. A request is always mergeable when it enters the
hash, but it may not remain mergeable. This can happen if we merge it to
its maximum size, for instance.
--
Jens Axboe
next prev parent reply other threads:[~2013-01-07 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 5:08 [PATCH] block: Remove judgement for rq_mergeable(rq) in func elv_rqhash_find majianpeng
2013-01-07 7:54 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-01-07 2:44 majianpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EA7F3A.2010601@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=majianpeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.