From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39617)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TsGJj-00051i-Dt
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 12:16:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TsGJi-0008HS-6H
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 12:16:55 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:45432)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TsGJi-0008HN-0E
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 12:16:54 -0500
Message-ID: <50EB0303.8060402@weilnetz.de>
Date: Mon, 07 Jan 2013 18:16:51 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1357336668-15518-1-git-send-email-sw@weilnetz.de>
	<50EA88B7.8000607@redhat.com>
In-Reply-To: <50EA88B7.8000607@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org

Am 07.01.2013 09:35, schrieb Gerd Hoffmann:
> On 01/04/13 22:57, Stefan Weil wrote:
>> pc-testdev.c cannot be compiled with MinGW:
>>
>>    CC    i386-softmmu/hw/i386/../pc-testdev.o
>> hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
>> hw/i386/../pc-testdev.c: In function =E2=80=98test_flush_page=E2=80=99=
:
>> hw/i386/../pc-testdev.c:103: warning: implicit declaration of function=
 =E2=80=98mprotect=E2=80=99
>> ...
>
>> +obj-$(CONFIG_KVM) +=3D pc-testdev.o
>
> CONFIG_POSIX is the better choice I think.
>
> cheers,
>    Gerd

I agree.

This patch was superseded by a newer one which indeed uses
CONFIG_POSIX and was applied by Blue, see

http://patchwork.ozlabs.org/patch/209653/

Cheers,
Stefan