From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Date: Mon, 07 Jan 2013 17:53:32 +0000 Subject: Re: [PATCH] sctp: fix Kconfig bug in default cookie hmac selection Message-Id: <50EB0B9C.2010001@gmail.com> List-Id: References: <50EAFC32.9030104@inktank.com> In-Reply-To: <50EAFC32.9030104@inktank.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sctp@vger.kernel.org On 01/07/2013 11:47 AM, Alex Elder wrote: > The following commit added a "choice" to the sctp Kconfig file. It > introduced a bug which led to an infinite loop when while running > "make oldconfig". > > 0d0863b0 sctp: Change defaults on cookie hmac selection > > The problem is that the wrong symbol was defined as the default > value for the choice. Using the correct value gets rid of the > infinite loop. > > Note: if CONFIG_SCTP_COOKIE_HMAC_SHA1=y was present in the input > config file, both that and CONFIG_SCTP_COOKIE_HMAC_MD5=y be present > in the generated config file. > > Signed-off-by: Alex Elder > --- > net/sctp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sctp/Kconfig b/net/sctp/Kconfig > index c262106..7521d94 100644 > --- a/net/sctp/Kconfig > +++ b/net/sctp/Kconfig > @@ -68,7 +68,7 @@ config SCTP_DBG_OBJCNT > If unsure, say N > choice > prompt "Default SCTP cookie HMAC encoding" > - default SCTP_COOKIE_HMAC_MD5 > + default SCTP_DEFAULT_COOKIE_HMAC_MD5 > help > This option sets the default sctp cookie hmac algorithm > when in doubt select 'md5' > Tested-by: Vlad Yasevich Acked-by: Vlad Yasevich This does resolve the loop and makes the oldconfig behavior consistent with menuconfig. -vlad