From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW
Date: Mon, 07 Jan 2013 16:14:00 -0200 [thread overview]
Message-ID: <50EB1068.6070600@redhat.com> (raw)
In-Reply-To: <50EB0303.8060402@weilnetz.de>
On 01/07/2013 03:16 PM, Stefan Weil wrote:
> Am 07.01.2013 09:35, schrieb Gerd Hoffmann:
>> On 01/04/13 22:57, Stefan Weil wrote:
>>> pc-testdev.c cannot be compiled with MinGW:
>>>
>>> CC i386-softmmu/hw/i386/../pc-testdev.o
>>> hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
>>> hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
>>> hw/i386/../pc-testdev.c:103: warning: implicit declaration of
>>> function ‘mprotect’
>>> ...
>>
>>> +obj-$(CONFIG_KVM) += pc-testdev.o
>>
>> CONFIG_POSIX is the better choice I think.
>>
>> cheers,
>> Gerd
>
> I agree.
>
> This patch was superseded by a newer one which indeed uses
> CONFIG_POSIX and was applied by Blue, see
>
> http://patchwork.ozlabs.org/patch/209653/
>
> Cheers,
> Stefan
Ok, sorry about that, guys, and thanks for fixing things.
Lucas
prev parent reply other threads:[~2013-01-07 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 21:57 [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW Stefan Weil
2013-01-07 8:35 ` Gerd Hoffmann
2013-01-07 17:16 ` Stefan Weil
2013-01-07 18:14 ` Lucas Meneghel Rodrigues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EB1068.6070600@redhat.com \
--to=lmr@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.