From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1TsJUn-0003UY-A9
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:40:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1TsJUm-0006VX-BE
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:40:33 -0500
Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:37717)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1TsJUm-0006VG-30
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:40:32 -0500
Received: from /spool/local
	by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Mon, 7 Jan 2013 20:39:48 -0000
Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com
	[9.149.37.228])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id r07KeKrj5374358
	for <qemu-devel@nongnu.org>; Mon, 7 Jan 2013 20:40:20 GMT
Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id r07KeSNK017176
	for <qemu-devel@nongnu.org>; Mon, 7 Jan 2013 13:40:28 -0700
Message-ID: <50EB32BB.5040302@de.ibm.com>
Date: Mon, 07 Jan 2013 21:40:27 +0100
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1355760006-891-1-git-send-email-borntraeger@de.ibm.com>
	<874nisvlfv.fsf@codemonkey.ws>
In-Reply-To: <874nisvlfv.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qdev: obey no_user
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, =?ISO-8859-1?Q?Andre?= =?ISO-8859-1?Q?as_F=E4rber?= <afaerber@suse.de>

On 07/01/13 20:32, Anthony Liguori wrote:
> Christian Borntraeger <borntraeger@de.ibm.com> writes:
> 
>> since
>>
>> commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96
>> qdev: refactor device creation to allow bus_info to be set only in class
>>
>> A user can specify a device that is no_user.
>> For example on my i386 box, I can add a 2nd kvmvapic device.
>>
>> This patch checks for no-user and rejects the device_add.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> 
> I specifically broke this when QOM was introduced because no_user
> precludes a management tool from constructing a machine directlt.

Breaking it but leaving it in the code doesnt seem to be the right thing.
The commit message from 18b6dade doesnt give any hint that this is now
broken and nobody audited the callers of no_user that they handle things
gracefully.

So whats the plan? Totally remove no_user tree-wide?

Christian