From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsSAm-0006VK-Ao for qemu-devel@nongnu.org; Tue, 08 Jan 2013 00:56:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsSAl-0003tR-1m for qemu-devel@nongnu.org; Tue, 08 Jan 2013 00:56:28 -0500 Received: from dns1.mips.com ([12.201.5.69]:37299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsSAk-0003tN-PM for qemu-devel@nongnu.org; Tue, 08 Jan 2013 00:56:26 -0500 Message-ID: <50EBB21E.7070905@mips.com> Date: Mon, 7 Jan 2013 21:43:58 -0800 From: Eric Johnson MIME-Version: 1.0 References: <1355931071-22100-1-git-send-email-afaerber@suse.de> <1355931071-22100-3-git-send-email-afaerber@suse.de> In-Reply-To: <1355931071-22100-3-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 2/7] target-mips: Clean up mips_cpu_map_tc() documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org, Aurelien Jarno On 12/19/2012 07:31 AM, Andreas F=C3=A4rber wrote: > This function will be touched again soon, so a good understanding of en= v > vs. other helps. Adopt gtk-doc style. > > Signed-off-by: Andreas F=C3=A4rber > --- > target-mips/op_helper.c | 14 +++++++++----- > 1 Datei ge=C3=A4ndert, 9 Zeilen hinzugef=C3=BCgt(+), 5 Zeilen entfern= t(-) > > diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c > index f9f2b23..83998ab 100644 > --- a/target-mips/op_helper.c > +++ b/target-mips/op_helper.c > @@ -573,11 +573,15 @@ static inline void mips_tc_sleep(MIPSCPU *cpu, in= t tc) > } > } > > -/* tc should point to an int with the value of the global TC index. > - This function will transform it into a local index within the > - returned CPUMIPSState. > - > - FIXME: This code assumes that all VPEs have the same number of TCs, > +/** > + * mips_cpu_map_tc: > + * @env: CPU from which mapping is performed. > + * @tc: Should point to an int with the value of the global TC index. > + * > + * This function will transform @tc into a local index within the > + * returned #CPUMIPSState. > + */ > +/* FIXME: This code assumes that all VPEs have the same number of TCs, > which depends on runtime setup. Can probably be fixed by > walking the list of CPUMIPSStates. */ > static CPUMIPSState *mips_cpu_map_tc(CPUMIPSState *env, int *tc) Reviewed-by: Eric Johnson