From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com ([134.134.136.24]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TsaoN-0001fr-23 for openembedded-core@lists.openembedded.org; Tue, 08 Jan 2013 16:10:00 +0100 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 08 Jan 2013 06:53:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,430,1355126400"; d="scan'208,217";a="243455832" Received: from dell-desktop (HELO [10.237.105.59]) ([10.237.105.59]) by orsmga001.jf.intel.com with ESMTP; 08 Jan 2013 06:54:41 -0800 Message-ID: <50EC34AF.5010303@intel.com> Date: Tue, 08 Jan 2013 17:01:03 +0200 From: Radu Moisan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Enrico Scholz References: In-Reply-To: Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 00/21][RFC v3] systemd Integration X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2013 15:10:02 -0000 Content-Type: multipart/alternative; boundary="------------060603020707080200020005" --------------060603020707080200020005 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 01/08/2013 02:57 PM, Enrico Scholz wrote: > Radu Moisan > writes: > >> Enrico Scholz (1): >> systemd: move disable operation into prerm() script > http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=e01411c2400231a89bc76a229b38e7eb95b7cd81 > > I am pretty sure that I added a 'Signed-off-by:' field to my patch but > it is missing in the commit. Other patches don't have the signed-off-by > of the original author neither. > > Was this removal done on purpose? I had to port the patch manually so I guess it got lost then. Do we want to have Sign-off-by from author as well? >> systemd: Introduce a create-volatile to create tmp directories > http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=64de9a773c1ac79d4dbcb041ed7e66c19a3cf6b7 > > When/because the order of files is really important, they should be installed > with the usual - prefix method (e.g. '00-create-volatile.conf'). > > Else, when e.g. /var/cache/apache is created by a 3rd part recipe, it > requires (yet more) ugly naming tricks (e.g. naming it > 'zz-apache-httpd.conf') to ensure the correct order and it might break > easily when something else is changed. > You have a point here. Noted. Radu --------------060603020707080200020005 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit
On 01/08/2013 02:57 PM, Enrico Scholz wrote:
Radu Moisan <radu.moisan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
writes:


Enrico Scholz (1):
  systemd: move disable operation into prerm() script

   http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=e01411c2400231a89bc76a229b38e7eb95b7cd81

I am pretty sure that I added a 'Signed-off-by:' field to my patch but
it is missing in the commit.  Other patches don't have the signed-off-by
of the original author neither.

Was this removal done on purpose?

I had to port the patch manually so I guess it got lost then. Do we want to have Sign-off-by from author as well?

  systemd: Introduce a create-volatile to create tmp directories

   http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=64de9a773c1ac79d4dbcb041ed7e66c19a3cf6b7

When/because the order of files is really important, they should be installed
with the usual <number>- prefix method (e.g. '00-create-volatile.conf').

Else, when e.g. /var/cache/apache is created by a 3rd part recipe, it
requires (yet more) ugly naming tricks (e.g. naming it
'zz-apache-httpd.conf') to ensure the correct order and it might break
easily when something else is changed.
You have a point here. Noted.

Radu
--------------060603020707080200020005--