From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TsbvP-0002bA-Fe
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 11:21:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TsbvO-0001go-94
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 11:21:15 -0500
Received: from cantor2.suse.de ([195.135.220.15]:33533 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TsbfL-0005sY-CI
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 11:04:39 -0500
Message-ID: <50EC4394.3060001@suse.de>
Date: Tue, 08 Jan 2013 17:04:36 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1356724895-24118-1-git-send-email-imammedo@redhat.com>
	<1356724895-24118-3-git-send-email-imammedo@redhat.com>
In-Reply-To: <1356724895-24118-3-git-send-email-imammedo@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 02/20] target-i386: sanitize AMD's
 ext2_features at realize time
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com

Am 28.12.2012 21:01, schrieb Igor Mammedov:
> @@ -2062,6 +2052,17 @@ void x86_cpu_realize(Object *obj, Error **errp)
>          env->cpuid_level =3D 7;
>      }
> =20
> +    /* On AMD CPUs, some CPUID[8000_0001].EDX bits must match the bits=
 on
> +     * CPUID[1].EDX.
> +     */
> +    if (env->cpuid_vendor1 =3D=3D CPUID_VENDOR_AMD_1 &&
> +        env->cpuid_vendor2 =3D=3D CPUID_VENDOR_AMD_2 &&
> +        env->cpuid_vendor3 =3D=3D CPUID_VENDOR_AMD_3) {
> +        env->cpuid_ext2_features &=3D ~CPUID_EXT2_AMD_ALIASES;
> +        env->cpuid_ext2_features |=3D (env->cpuid_features
> +           &  CPUID_EXT2_AMD_ALIASES);

I've dropped the extra space above.

Andreas

> +    }
> +
>      if (!kvm_enabled()) {
>          env->cpuid_features &=3D TCG_FEATURES;
>          env->cpuid_ext_features &=3D TCG_EXT_FEATURES;
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg