From: Larry Finger <Larry.Finger@lwfinger.net>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, Stable <stable@vger.kernel.org>,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
ath9k-devel@lists.ath9k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath9k_htc: Fix skb leaks
Date: Tue, 08 Jan 2013 10:09:25 -0600 [thread overview]
Message-ID: <50EC44B5.6020605@lwfinger.net> (raw)
In-Reply-To: <20707.50445.510814.481023@gargle.gargle.HOWL>
On 01/01/2013 11:26 PM, Sujith Manoharan wrote:
> Larry Finger wrote:
>> My only counter argument is that none of the other paths that get to
>> ath9k_htc_txcompletion_cb() leak the skb. It only happens for the path that goes
>> through htc_connect_service().
>
> Sure, but the TX completion handler would be invoked for every skb that is passed
> to the USB layer, including the ones that are allocated in htc_hst.c. When this
> skb goes down to hif_usb.c, a URB is allocated and I am not sure how freeing
> the skb before the USB layer invokes the completion handler for the URB is correct.
>
> I'll come up with a patch and see if kmemleak still complains.
Did I miss your posting on this issue?
Larry
next prev parent reply other threads:[~2013-01-08 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 3:49 [PATCH] ath9k_htc: Fix skb leaks Larry Finger
2013-01-02 4:30 ` Sujith Manoharan
2013-01-02 4:30 ` Sujith Manoharan
2013-01-02 4:57 ` Larry Finger
2013-01-02 5:26 ` Sujith Manoharan
2013-01-08 16:09 ` Larry Finger [this message]
2013-01-09 8:19 ` Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EC44B5.6020605@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=senthilb@qca.qualcomm.com \
--cc=stable@vger.kernel.org \
--cc=sujith@msujith.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.