All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Asleson <tasleson@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 2/3] lvm2app: Implementation of lv resize (v1)
Date: Wed, 09 Jan 2013 00:25:58 -0600	[thread overview]
Message-ID: <50ED0D76.7070702@redhat.com> (raw)
In-Reply-To: <50EBF879.7080201@redhat.com>

On 01/08/2013 04:44 AM, Zdenek Kabelac wrote:
> I'd prefer here to see separate patches which are
> just moving code and then new patches for changes
> of moved code.

New patch set submitted.  Some changes needed to occur to allow the code
to be moved.  This is broken down step by step.  Hopefully this will
make it easier to see what is going on.

> After moving code - try to add  '_' prefixes to internal 'static'
> functions.

OK

> we have macro shortcut - return_0;

Using it now.

> goto_out

Using this too...

> {} around single commands unneeded

OK

Thanks,
Tony



  reply	other threads:[~2013-01-09  6:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 21:02 [PATCH 1/3] lvm2app: Implementation of pv resize (v4) Tony Asleson
2013-01-07 21:02 ` [PATCH 2/3] lvm2app: Implementation of lv resize (v1) Tony Asleson
2013-01-08 10:44   ` Zdenek Kabelac
2013-01-09  6:25     ` Tony Asleson [this message]
2013-01-07 21:02 ` [PATCH 3/3] python-lvm: Add ability to disable vg auto write (v1) Tony Asleson
2013-01-08 10:37 ` [PATCH 1/3] lvm2app: Implementation of pv resize (v4) Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50ED0D76.7070702@redhat.com \
    --to=tasleson@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.