All of lore.kernel.org
 help / color / mirror / Atom feed
From: Victor Goldenshtein <victorg@ti.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: <linux-wireless@vger.kernel.org>, <johannes@sipsolutions.net>
Subject: Re: [PATCH] mac80211: fix delayed ADDBA response
Date: Wed, 9 Jan 2013 10:39:35 +0200	[thread overview]
Message-ID: <50ED2CC7.5060609@ti.com> (raw)
In-Reply-To: <20130108174111.GB20290@thinkpad-t410>

On 08/01/13 19:41, Seth Forshee wrote:
> On Tue, Jan 08, 2013 at 04:16:37PM +0200, Victor Goldenshtein wrote:
>> Block frame processing during scan might delay the
>> ADDBA response, which eventually timeouts and
>> significantly reduces the device throughput.
>> Remove this constrain as it's not required for the
>> HW scan.
>>
>> Signed-off-by: Victor Goldenshtein<victorg@ti.com>
>> ---
>>   net/mac80211/iface.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
>> index 06fac29..a26ee36 100644
>> --- a/net/mac80211/iface.c
>> +++ b/net/mac80211/iface.c
>> @@ -1063,7 +1063,7 @@ static void ieee80211_iface_work(struct work_struct *work)
>>   	if (!ieee80211_sdata_running(sdata))
>>   		return;
>>
>> -	if (local->scanning)
>> +	if (local->scanning&&  !local->ops->hw_scan)
>
> Wouldn't checking for SCAN_HW_SCANNING be better?
>

IMHO it's totally the same, besides that mac80211 use this check in many 
other places, but lets see what Johannes thinks.

-- 
Thanks,
Victor.

  reply	other threads:[~2013-01-09  8:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 14:16 [PATCH] mac80211: fix delayed ADDBA response Victor Goldenshtein
2013-01-08 17:41 ` Seth Forshee
2013-01-09  8:39   ` Victor Goldenshtein [this message]
2013-01-09 12:38 ` Johannes Berg
2013-01-09 16:04   ` Victor Goldenshtein
2013-01-09 16:32     ` Johannes Berg
2013-01-09 17:25       ` Arik Nemtsov
2013-01-09 17:29         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50ED2CC7.5060609@ti.com \
    --to=victorg@ti.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.