Re: [PATCH 2/3] gcc: remove the 64bithack patch

[Constantin Musca <constantinx.musca@intel.com>]

On 01/09/2013 03:45 PM, Richard Purdie wrote:
> On Wed, 2013-01-09 at 11:00 +0200, Constantin Musca wrote:
>> Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
>> ---
>>   meta/recipes-devtools/gcc/gcc-4.7.inc             |  1 -
>>   meta/recipes-devtools/gcc/gcc-4.7/64bithack.patch | 63 -----------------------
>>   2 files changed, 64 deletions(-)
>>   delete mode 100644 meta/recipes-devtools/gcc/gcc-4.7/64bithack.patch
> Does removing this break multilib builds? For example, with different
> libdir layouts?
I think it's going to break other multilib builds. The solution is to 
keep the 64bithack.patch for setting the default multilib options.  The 
3/3 patch can be used without PATCH 2/3.
> Note that gcc has a shared source tree so patches cannot by applied in
> say the cross case when we need this yet not in the target case when we
> probably don't want it. We need to make a patch which works in all
> cases.
The other gcc variants (e.g. gcc-cross) are configured using 
--disable-multilib as option and they will not be influenced if we 
modify the multilib files.
>
> Cheers,
>
> Richard
>
>

Cheers,
Constantin