From: Jason Luan <luanjianhai@163.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: netdev@vger.kernel.org, xen-devel@lists.xensource.com,
Ian Campbell <Ian.Campbell@citrix.com>,
konrad.wilk@oracle.com
Subject: Re: xen-netback notify DomU to send ARP.
Date: Wed, 09 Jan 2013 23:37:55 +0800 [thread overview]
Message-ID: <50ED8ED3.8010007@163.com> (raw)
In-Reply-To: <50ED825802000078000B4113@nat28.tlf.novell.com>
于 2013年01月09日 21:44, Jan Beulich 写道:
>>>> On 09.01.13 at 13:28, jianhai luan <jianhai.luan@oracle.com> wrote:
>>>> + switch (event) {
>>>> + case NETDEV_NOTIFY_PEERS:
>>>> + /* Notify frontend to Send gratuitous ARP */
>>>> + xenbus_switch_state(be->dev, XenbusStateInitialised);
>>>> + xenbus_switch_state(be->dev, );
>>> This is the sort of change that clearly isn't acceptable, as I don't
>>> think you have ways to check _all_ existing frontends for their
>>> compatibility with this. A connected -> connected transition
>>> might be acceptable (that was done in the block frontend too, for
>>> implementing dynamic resize), but will likely need to be
>>> accompanied by a frontend side patch to handle that (which so
>>> far should be a no-op).
>> The latest xen net-frontent driver have handled the condition. State
>> XenbusStateInitialised will do nothing,
>> but change to XenbusStateConnected will trigger
>> netdev_notify_peers(netdev) to send ARP.
> Did you read my earlier reply carefully? You still only talk about
> (upstream) Linux netfront, but this is not the only (possible)
> frontend. You should not invoke state transitions that can -
> even if only theoretically - blow up frontends. And afaict the
I only want to notify xen-netfront. I don't know what is better way?
To attainthegoal, i try to modify virtual interrupt, but the way is
morecomplicated,modified and working. So, i give up the way.
Would you like to give some suggestion about how to notify xen-netfront?
> only thing you can safely assume frontends ought to tolerate
> are transitions from Connected to Connected (or more
> generally from one state to the same one, but the other
> states aren't useful here, except maybe the Reconfigur* ones).
Sorry for that. At the beginning the patch be applied in kernel 2.6.18 to
fixed one issue. Only XenbusStateInitialised and XenbusStateClosed ( Not
Reconfigure* one) don't any thing, so i choose the XenbusStateInitialised.
Do you suggestion that i choose Reconfigure*?
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-01-09 15:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 11:57 xen-netback notify DomU to send ARP jianhai luan
2013-01-08 13:13 ` [Xen-devel] " Jan Beulich
2013-01-08 13:13 ` Jan Beulich
2013-01-08 13:42 ` Ian Campbell
2013-01-08 15:40 ` jianhai luan
2013-01-08 15:40 ` jianhai luan
2013-01-08 16:00 ` [Xen-devel] " Ian Campbell
2013-01-09 1:07 ` Jason Luan
2013-01-09 12:03 ` [Xen-devel] " Ian Campbell
2013-01-09 7:39 ` jianhai luan
2013-01-09 10:06 ` Jan Beulich
2013-01-09 10:06 ` Jan Beulich
2013-01-09 12:28 ` jianhai luan
2013-01-09 12:28 ` jianhai luan
2013-01-09 13:44 ` Jan Beulich
2013-01-09 13:44 ` Jan Beulich
2013-01-09 15:37 ` Jason Luan [this message]
2013-01-09 15:44 ` Jan Beulich
2013-01-09 15:44 ` Jan Beulich
[not found] ` <50ED950A.6010203@163.com>
2013-01-09 16:25 ` Jan Beulich
[not found] ` <50EDA624.1010008@163.com>
2013-01-10 7:00 ` [Xen-devel] " jianhai luan
2013-01-10 15:20 ` Jason Luan
2013-01-13 1:51 ` Jason Luan
2013-01-14 12:16 ` Ian Campbell
2013-01-14 13:39 ` Jason Luan
2013-01-14 14:24 ` Jan Beulich
2013-01-14 14:43 ` Jason Luan
2013-01-14 15:52 ` Jan Beulich
[not found] ` <50EF7106.7000302@oracle.com>
2013-01-21 7:26 ` [V2] " jianhai luan
2013-01-21 11:04 ` David Vrabel
2013-01-21 11:33 ` Jason Luan
2013-01-21 11:55 ` Jan Beulich
2013-01-21 12:23 ` Ian Campbell
2013-01-21 12:30 ` Ian Campbell
2013-01-21 12:38 ` [Xen-devel] " Jason Luan
2013-01-21 12:38 ` Jason Luan
2013-01-21 13:49 ` Jason Luan
2013-01-21 13:52 ` Ian Campbell
2013-01-21 14:02 ` Jason Luan
2013-01-21 14:09 ` Ian Campbell
2013-01-21 14:16 ` Jan Beulich
2013-01-21 14:31 ` Jason Luan
2013-01-21 14:54 ` Jason Luan
2013-01-21 15:20 ` Jan Beulich
2013-01-21 15:30 ` Jason Luan
2013-01-21 15:44 ` Jan Beulich
2013-01-21 15:56 ` Jason Luan
2013-01-21 15:59 ` Jan Beulich
2013-01-21 16:02 ` Jason Luan
2013-01-21 15:59 ` Ian Campbell
2013-01-21 12:25 ` Jason Luan
-- strict thread matches above, loose matches on Subject: below --
2013-01-09 15:07 Jason Luan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ED8ED3.8010007@163.com \
--to=luanjianhai@163.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.