From: Miao Xie <miaox@cn.fujitsu.com>
To: dsterba@suse.cz
Cc: Linux Fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Btrfs <linux-btrfs@vger.kernel.org>,
Linux Ext4 <linux-ext4@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Kamal Mostafa <kamal@canonical.com>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH RESEND] vfs: re-implement writeback_inodes_sb(_nr)_if_idle() and rename them
Date: Thu, 10 Jan 2013 11:24:15 +0800 [thread overview]
Message-ID: <50EE345F.1090600@cn.fujitsu.com> (raw)
In-Reply-To: <20121228143338.GW14116@twin.jikos.cz>
On Fri, 28 Dec 2012 15:33:38 +0100, David Sterba wrote:
> On Thu, Dec 20, 2012 at 06:09:35PM +0800, Miao Xie wrote:
>> --- a/fs/fs-writeback.c
>> +++ b/fs/fs-writeback.c
>> @@ -1314,7 +1314,6 @@ void writeback_inodes_sb_nr(struct super_block *sb,
>> bdi_queue_work(sb->s_bdi, &work);
>> wait_for_completion(&done);
>> }
>> -EXPORT_SYMBOL(writeback_inodes_sb_nr);
>
> Why do you remove the export? writeback_inodes_sb is exported as well.
As you said below, there is no user now.
> Originally the _nr variant has been introduced for btrfs
> (3259f8bed2f0f57c2fdcdac1b510c3fa319ef97e) and there are no other users
> now, so from that point it would make sense. From the other side, the
> change is not strictly necessary for this patch and keeps the writeback
> API a bit more flexible. I vote for keeping it.
Maybe you are right, I'll send out a new one.
> Otherwise (for the btrfs part),
> Tested-by: David Sterba <dsterba@suse.cz>
Thanks for your test and review.
Miao
next prev parent reply other threads:[~2013-01-10 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 10:09 [PATCH RESEND] vfs: re-implement writeback_inodes_sb(_nr)_if_idle() and rename them Miao Xie
2012-12-28 14:33 ` David Sterba
2013-01-10 3:24 ` Miao Xie [this message]
2013-01-10 5:47 ` [PATCH V2] " Miao Xie
2013-01-11 20:12 ` Jan Kara
2013-01-12 2:54 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EE345F.1090600@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=hch@infradead.org \
--cc=kamal@canonical.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.