All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH][v2] linux-user, alpha: l_type of fcntl() flock differs
Date: Thu, 10 Jan 2013 13:05:41 -0800	[thread overview]
Message-ID: <50EF2D25.4080601@twiddle.net> (raw)
In-Reply-To: <1357850568-7626-1-git-send-email-laurent@vivier.eu>

On 01/10/2013 12:42 PM, Laurent Vivier wrote:
> +static const bitmask_transtbl flock_tbl[] = {
> +    TRANSTBL_CONVERT(F_RDLCK),
> +    TRANSTBL_CONVERT(F_WRLCK),
> +    TRANSTBL_CONVERT(F_UNLCK),
> +    TRANSTBL_CONVERT(F_EXLCK),
> +    TRANSTBL_CONVERT(F_SHLCK),
> +    { 0, 0, 0, 0 }
> +};

Oh, I forgot to mention that you'll need to protect against the
case of F_RDLCK == 0 && TARGET_F_RDLCK == 0.  The easiest way to
handle this is place that entry last.


r~

  reply	other threads:[~2013-01-10 21:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 22:24 [Qemu-devel] [PATCH] linux-user, alpha: l_type of fcntl() flock differs Laurent Vivier
2013-01-07 23:06 ` Richard Henderson
2013-01-08  9:18   ` Laurent Vivier
2013-01-10 20:42 ` [Qemu-devel] [PATCH][v2] " Laurent Vivier
2013-01-10 21:05   ` Richard Henderson [this message]
2013-01-10 21:10     ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EF2D25.4080601@twiddle.net \
    --to=rth@twiddle.net \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.