From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41468)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TtQ7u-0008Ly-JA
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 16:57:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TtQ7s-0004Jq-SN
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 16:57:30 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:52117)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TtQ7s-0004Jf-LG
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 16:57:28 -0500
Message-ID: <50EF3945.4090802@weilnetz.de>
Date: Thu, 10 Jan 2013 22:57:25 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1357854407-7093-1-git-send-email-meadori@codesourcery.com>
In-Reply-To: <1357854407-7093-1-git-send-email-meadori@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the
 appropriate signal
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Meador Inge <meadori@codesourcery.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

Am 10.01.2013 22:46, schrieb Meador Inge:
> GCC and GAS are capable of generating traps or breaks to check for
> division by zero.  Additionally, GAS is capable of generating traps
> or breaks to check for overflow on certain division and multiplication
> operations.  The Linux kernel translates these traps and breaks into
> signals.  This patch implements the corresponding feature in QEMU.
>
> Signed-off-by: Meador Inge <meadori@codesourcery.com>
> ---
>   linux-user/main.c |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
>   target-mips/cpu.h |    6 +++++
>   2 files changed, 69 insertions(+), 1 deletion(-)
>
>


Hi,

please check your patch before submitting it to qemu-devel.
See also http://wiki.qemu.org/Contribute/SubmitAPatch.

Regards,

Stefan W.


$ scripts/checkpatch.pl 
0001-MIPS-Translate-breaks-and-traps-into-the-appropriate.patch
WARNING: braces {} are necessary for all arms of this statement
#62: FILE: linux-user/main.c:2329:
+                if (ret != 0)
[...]

WARNING: braces {} are necessary for all arms of this statement
#70: FILE: linux-user/main.c:2337:
+                if (code >= (1 << 10))
[...]

WARNING: braces {} are necessary for all arms of this statement
#73: FILE: linux-user/main.c:2340:
+                if (do_break(env, &info, code) != 0)
[...]

WARNING: braces {} are necessary for all arms of this statement
#83: FILE: linux-user/main.c:2350:
+                if (ret != 0)
[...]

WARNING: braces {} are necessary for all arms of this statement
#87: FILE: linux-user/main.c:2354:
+                if (!(trap_instr & 0xFC000000))
[...]

WARNING: braces {} are necessary for all arms of this statement
#90: FILE: linux-user/main.c:2357:
+                if (do_break(env, &info, code) != 0)
[...]

total: 0 errors, 6 warnings, 89 lines checked

0001-MIPS-Translate-breaks-and-traps-into-the-appropriate.patch has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.