From: Randy Dunlap <rdunlap@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: linux-next: Tree for Jan 10 (staging/sb105x)
Date: Thu, 10 Jan 2013 14:06:34 -0800 [thread overview]
Message-ID: <50EF3B6A.70704@infradead.org> (raw)
In-Reply-To: <1357851057.5141.16.camel@gandalf.local.home>
On 01/10/13 12:50, Steven Rostedt wrote:
> On Thu, 2013-01-10 at 11:08 -0800, Randy Dunlap wrote:
>> On 01/09/13 19:32, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20130109:
>>>
>>
>> on x86_64, when CONFIG_PARPORT_PC is not enabled:
>>
>> drivers/built-in.o: In function `multi_init':
>> sb_pci_mp.c:(.init.text+0x15684): undefined reference to `parport_pc_probe_port'
>>
>>
>> Full randconfig file is attached.
>
> Ug, so https://lkml.org/lkml/2012/12/14/250 should have been
> CONFIG_PARPORT_PC and not just PARPORT :-P
>
> Can you try this patch:
That's good. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> diff --git a/drivers/staging/sb105x/sb_pci_mp.c b/drivers/staging/sb105x/sb_pci_mp.c
> index 131afd0c..9464f38 100644
> --- a/drivers/staging/sb105x/sb_pci_mp.c
> +++ b/drivers/staging/sb105x/sb_pci_mp.c
> @@ -3054,7 +3054,7 @@ static int init_mp_dev(struct pci_dev *pcidev, mppcibrd_t brd)
> sbdev->nr_ports = ((portnum_hex/16)*10) + (portnum_hex % 16);
> }
> break;
> -#ifdef CONFIG_PARPORT
> +#ifdef CONFIG_PARPORT_PC
> case PCI_DEVICE_ID_MP2S1P :
> sbdev->nr_ports = 2;
>
>
>
> --
--
~Randy
next prev parent reply other threads:[~2013-01-10 22:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 3:32 linux-next: Tree for Jan 10 Stephen Rothwell
2013-01-10 3:32 ` Stephen Rothwell
2013-01-10 19:08 ` linux-next: Tree for Jan 10 (staging/sb105x) Randy Dunlap
2013-01-10 20:50 ` Steven Rostedt
2013-01-10 22:06 ` Randy Dunlap [this message]
2013-01-12 0:42 ` Greg Kroah-Hartman
2013-01-12 1:17 ` [PATCH] staging/sb105x: PARPORT config is not good enough must use PARPORT_PC Steven Rostedt
2013-01-10 19:17 ` linux-next: Tree for Jan 10 (vmci) Randy Dunlap
2013-01-10 19:28 ` Randy Dunlap
2013-01-10 19:28 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EF3B6A.70704@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.