From: Meador Inge <meadori@codesourcery.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal
Date: Thu, 10 Jan 2013 16:27:41 -0600 [thread overview]
Message-ID: <50EF405D.2070604@codesourcery.com> (raw)
In-Reply-To: <CAFEAcA86O4e=mfBLyXJPqBmwJMUqS3p2brCmZLssNAsYOp_t-Q@mail.gmail.com>
On 01/10/2013 04:12 PM, Peter Maydell wrote:
> This is an OS/ABI specific define, right? I don't think it
> belongs in the target-mips header file. Since it only has one
> user, I think you could reasonably just put it in linux-user/main.c.
The enum will only be used in the MIPS CPU loop. I originally put it in
target-mips/cpu.h because that is where the exception codes
are defined. However, the one user argument makes sense to me. I
moved the enum definition.
Thanks for the review.
--
Meador Inge
CodeSourcery / Mentor Embedded
prev parent reply other threads:[~2013-01-10 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 21:46 [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal Meador Inge
2013-01-10 21:57 ` Stefan Weil
2013-01-10 22:15 ` Meador Inge
2013-01-10 22:12 ` Peter Maydell
2013-01-10 22:27 ` Meador Inge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EF405D.2070604@codesourcery.com \
--to=meadori@codesourcery.com \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.