From: Jason Wang <jasowang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: stefanha@redhat.com, mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3.8-rc] tuntap: refuse to re-attach to different tun_struct
Date: Fri, 11 Jan 2013 09:29:20 +0800 [thread overview]
Message-ID: <50EF6AF0.1020005@redhat.com> (raw)
In-Reply-To: <20130110.143902.2166041015759450388.davem@davemloft.net>
On 01/11/2013 06:39 AM, David Miller wrote:
> From: Stefan Hajnoczi <stefanha@redhat.com>
> Date: Thu, 10 Jan 2013 08:59:48 +0100
>
>> Multiqueue tun devices support detaching a tun_file from its tun_struct
>> and re-attaching at a later point in time. This allows users to disable
>> a specific queue temporarily.
>>
>> ioctl(TUNSETIFF) allows the user to specify the network interface to
>> attach by name. This means the user can attempt to attach to interface
>> "B" after detaching from interface "A".
>>
>> The driver is not designed to support this so check we are re-attaching
>> to the right tun_struct. Failure to do so may lead to oops.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> Applied.
Hi David:
Any chance that I can have a respin on this patch, there's still a bug
after this patch. Or I just can send a patch on top?
Thanks
next prev parent reply other threads:[~2013-01-11 1:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 7:59 [PATCH 3.8-rc] tuntap: refuse to re-attach to different tun_struct Stefan Hajnoczi
2013-01-10 9:25 ` Jason Wang
2013-01-10 10:23 ` Michael S. Tsirkin
2013-01-10 10:43 ` Jason Wang
2013-01-10 11:07 ` Michael S. Tsirkin
2013-01-10 13:53 ` Jason Wang
2013-01-10 11:53 ` Stefan Hajnoczi
2013-01-10 22:39 ` David Miller
2013-01-11 1:29 ` Jason Wang [this message]
2013-01-11 5:12 ` David Miller
2013-01-11 8:38 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EF6AF0.1020005@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.