All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org,
	chenwj@iis.sinica.edu.tw, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH V4 1/4] HMP: add QDict to info callback handler
Date: Fri, 11 Jan 2013 11:16:23 +0800	[thread overview]
Message-ID: <50EF8407.1030101@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130110111057.4508f8bb@doriath.home>

于 2013-1-10 21:10, Luiz Capitulino 写道:
> On Thu, 10 Jan 2013 16:32:31 +0800
> Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>
>> diff --git a/monitor.c b/monitor.c
>> index 9cf419b..c7b3014 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -123,7 +123,7 @@ typedef struct mon_cmd_t {
>>       const char *help;
>>       void (*user_print)(Monitor *mon, const QObject *data);
>>       union {
>> -        void (*info)(Monitor *mon);
>> +        void (*info)(Monitor *mon, const QDict *qdict);
>>           void (*cmd)(Monitor *mon, const QDict *qdict);
>
> Is it possible to eliminate 'info' and use 'cmd' instead?
>
   yes, now info is not a special case but a sub command.
If you agree I'll delete info function.

-- 
Best Regards

Wenchao Xia

  reply	other threads:[~2013-01-11  3:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10  8:32 [Qemu-devel] [PATCH V4 0/4] HMP: allow parsing for sub command Wenchao Xia
2013-01-10  8:32 ` [Qemu-devel] [PATCH V4 1/4] HMP: add QDict to info callback handler Wenchao Xia
2013-01-10 13:10   ` Luiz Capitulino
2013-01-11  3:16     ` Wenchao Xia [this message]
2013-01-10  8:32 ` [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command Wenchao Xia
2013-01-10 10:18   ` Markus Armbruster
2013-01-11  3:11     ` Wenchao Xia
2013-01-10 10:23   ` Markus Armbruster
2013-01-11  3:11     ` Wenchao Xia
2013-01-10 13:12   ` Luiz Capitulino
2013-01-11  3:17     ` Wenchao Xia
2013-01-10  8:32 ` [Qemu-devel] [PATCH V4 3/4] HMP: move define of mon_cmds Wenchao Xia
2013-01-10  8:32 ` [Qemu-devel] [PATCH V4 4/4] HMP: add sub command table to info Wenchao Xia
2013-01-10 10:24   ` Markus Armbruster
2013-01-11  3:13     ` Wenchao Xia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EF8407.1030101@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=chenwj@iis.sinica.edu.tw \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.