From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] The BUG() macro should print the correct
 architecture, not a hardcoded value.
Date: Fri, 11 Jan 2013 13:23:26 +0000
Message-ID: <50F0124E.8080405@citrix.com>
References: <1357910148-29868-1-git-send-email-lra@sics.se>
	<1357910412.20328.78.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1357910412.20328.78.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Lars Rasmusson <Lars.Rasmusson@sics.se>, "lra@sics.se" <lra@sics.se>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 11/01/13 13:20, Ian Campbell wrote:
> On Fri, 2013-01-11 at 13:15 +0000, lra@sics.se wrote:
>> From: Lars Rasmusson <Lars.Rasmusson@sics.se>
>>
>> Signed-off-by: Lars Rasmusson <Lars.Rasmusson@sics.se>
>> ---
>>  xen/arch/arm/traps.c |   18 +++++++++++++++++-
>>  1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
>> index f42e4e9..1909abf 100644
>> --- a/xen/arch/arm/traps.c
>> +++ b/xen/arch/arm/traps.c
>
>> @@ -68,7 +68,23 @@ static void print_xen_info(void)
>>      debug = 'y';
>>  #endif
>>  
>> -    printk("----[ Xen-%d.%d%s  x86_64  debug=%c  %s ]----\n",
> Oops!
>
>> +#ifdef CONFIG_ARM_32
>> +#define THE_ARCH "arm_32"
>> +#elif CONFIG_ARM_64
>> +#define THE_ARCH "arm_64"
> Since this is xen/arch/*arm*/traps.c you only need to handle these two
> cases.
>
> Ian.

Is there not a -D available from the Makefiles which would be
appropriate, to save having to change this every time a new architecture
is added?

~Andrew

>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel