All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
	alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 2/8] ASoC: Add support for virtual switch controls
Date: Fri, 11 Jan 2013 16:05:53 +0100	[thread overview]
Message-ID: <50F02A51.3010108@metafoo.de> (raw)
In-Reply-To: <20130111135754.GB20956@opensource.wolfsonmicro.com>

On 01/11/2013 02:57 PM, Mark Brown wrote:
> On Fri, Jan 11, 2013 at 01:56:17PM +0100, Lars-Peter Clausen wrote:
>> On 01/11/2013 01:45 PM, Mark Brown wrote:
> 
>>> Virtual enums do actually end up routing, that's not what a mute control
>>> usually does.  You can do the above in the manner I suggested, just have
>>> the register forced to a particular value when the DAC is disabled.
> 
>> Well, that's what the code does. The alternative is to implement more or
> 
> No, it's not (at least not according to the changelog).  It implements a
> totally separate virtual control.

What do you mean by 'separate'? Maybe this is was causes the confusion. Do
you mean a separate DAPM control, like DAPM_SWITCH? That's not what the
patch does it creates a virtual kcontrol, which can be used to control a
mixers input. It's the pendant to SOC_DAPM_ENUM_VIRT not to
SND_SOC_DAPM_VIRT_MUX. I realize that the commit message may have been a bit
ambiguous in that regard.

- Lars

  reply	other threads:[~2013-01-11 15:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 16:06 [PATCH 1/8] regmap: Add support for 24 bit wide register addresses Lars-Peter Clausen
2013-01-10 16:06 ` [PATCH 2/8] ASoC: Add support for virtual switch controls Lars-Peter Clausen
     [not found]   ` <1357833977-3682-2-git-send-email-lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-01-11 12:19     ` Mark Brown
2013-01-11 12:38       ` Lars-Peter Clausen
2013-01-11 12:45         ` Mark Brown
     [not found]           ` <20130111124535.GZ20956-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-01-11 12:56             ` Lars-Peter Clausen
2013-01-11 13:57               ` Mark Brown
2013-01-11 15:05                 ` Lars-Peter Clausen [this message]
     [not found]                   ` <50F02A51.3010108-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-01-11 15:08                     ` [alsa-devel] " Lars-Peter Clausen
2013-01-11 15:22                     ` Mark Brown
2013-01-11 16:24     ` Mark Brown
     [not found] ` <1357833977-3682-1-git-send-email-lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-01-10 16:06   ` [PATCH 3/8] ASoC: Add ADAU1X61 and ADAU1X81 CODECs common code Lars-Peter Clausen
2013-01-10 16:06   ` [PATCH 4/8] ASoC: Add ADAU1361/ADAU1761 CODEC support Lars-Peter Clausen
2013-01-10 16:06   ` [PATCH 5/8] ASoC: Add ADAU1381/ADAU1781 " Lars-Peter Clausen
2013-01-10 16:06   ` [PATCH 6/8] ASoC: Constify ops and compr_ops fields of snd_soc_dai_link Lars-Peter Clausen
2013-01-13 22:55     ` Mark Brown
2013-01-10 16:06   ` [PATCH 7/8] ASoC: Blackfin: ADAU1X61 eval board support Lars-Peter Clausen
2013-01-10 16:06   ` [PATCH 8/8] ASoC: Blackfin: ADAU1X81 " Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F02A51.3010108@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.