From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36682)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TtgSA-0001E8-B5
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:23:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TtgS5-0006dr-9u
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:23:30 -0500
Received: from cantor2.suse.de ([195.135.220.15]:38325 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TtgS5-0006dk-4E
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:23:25 -0500
Message-ID: <50F02E67.4080804@suse.de>
Date: Fri, 11 Jan 2013 16:23:19 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1357911723-12688-1-git-send-email-wolfgang.mauerer@siemens.com>
	<CAFEAcA-TC1FMQ96QrbS2f9K4yytgHa-GD-yDc1w35gpDJy7oNQ@mail.gmail.com>
In-Reply-To: <CAFEAcA-TC1FMQ96QrbS2f9K4yytgHa-GD-yDc1w35gpDJy7oNQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Realview/Versatile: Export LED state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, paul@codesourcery.com

Am 11.01.2013 16:00, schrieb Peter Maydell:
> On 11 January 2013 13:42, Wolfgang Mauerer <wolfgang.mauerer@siemens.co=
m> wrote:
>> The configuration register for the onboard LEDs is
>> emulated, but the state is not exported, which makes
>> the feature not particularly useful. Create a character
>> device to make status changes accessible to the host.
>>
>> For example, use the command line argument
>>
>> -chardev socket,id=3Dleds,host=3Dlocalhost,port=3D12345,server,nowait
>>
>> to observe status changes via a socket.
>=20
> This isn't the only board we emulate which has LEDs. I'd
> rather see this problem tackled with a general plan for "this
> is how we handle LEDs in QEMU boards" rather than a
> versatile board specific patch.

Hm, mips_malta.c does use a CharDriverState... just a more "structured"
one using ASCII art.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg