From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41017)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wolfgang.mauerer@siemens.com>) id 1Ttgk4-0002Dh-8H
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:42:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wolfgang.mauerer@siemens.com>) id 1Ttgk2-0003Xu-8s
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:42:00 -0500
Received: from gecko.sbs.de ([194.138.37.40]:21424)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wolfgang.mauerer@siemens.com>) id 1Ttgk1-0003Xb-UX
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:41:58 -0500
Message-ID: <50F033BD.5060907@siemens.com>
Date: Fri, 11 Jan 2013 16:46:05 +0100
From: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
MIME-Version: 1.0
References: <1357911723-12688-1-git-send-email-wolfgang.mauerer@siemens.com>
	<50F0287C.1010708@suse.de>
In-Reply-To: <50F0287C.1010708@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Realview/Versatile: Export LED state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "paul@codesourcery.com" <paul@codesourcery.com>

Hello,

On 11/01/13 15:58, Andreas F=E4rber wrote:
>> @@ -386,6 +406,10 @@ static int arm_sysctl_init(SysBusDevice *dev)
>> >  {
>> >      arm_sysctl_state *s =3D FROM_SYSBUS(arm_sysctl_state, dev);
>> > =20
>> > +    s->display =3D qemu_chr_new("leds0", "chardev:leds", NULL);
>> > +    if (s->display) {
> Can this ever be NULL?

if can be NULL if no leds chardev is available.

Best, Wolfgang