From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtiUy-0006fE-EZ for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:34:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtiUs-0000v4-MD for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:34:32 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43707 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtiUs-0000uo-GK for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:34:26 -0500 Message-ID: <50F04D1E.7070500@suse.de> Date: Fri, 11 Jan 2013 18:34:22 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1357829348-3496-1-git-send-email-pbonzini@redhat.com> <1357829348-3496-2-git-send-email-pbonzini@redhat.com> <50EF09A4.4010608@suse.de> In-Reply-To: <50EF09A4.4010608@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] qdev: add qbus_reset_all List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mst@redhat.com Am 10.01.2013 19:34, schrieb Andreas F=E4rber: > Am 10.01.2013 15:49, schrieb Paolo Bonzini: >> Signed-off-by: Paolo Bonzini >> --- >> hw/qdev-core.h | 12 ++++++++++++ >> hw/qdev.c | 7 ++++++- >> 2 files changed, 18 insertions(+), 1 deletion(-) >> >> diff --git a/hw/qdev-core.h b/hw/qdev-core.h >> index fdf14ec..853bd08 100644 >> --- a/hw/qdev-core.h >> +++ b/hw/qdev-core.h >> @@ -182,6 +182,18 @@ int qbus_walk_children(BusState *bus, qdev_walker= fn *devfn, >> int qdev_walk_children(DeviceState *dev, qdev_walkerfn *devfn, >> qbus_walkerfn *busfn, void *opaque); >> void qdev_reset_all(DeviceState *dev); >> + >> +/** >> + * @qbus_reset_all: >=20 > Just " * qbus_reset_all:" please. Patch was applied nontheless, please fix in a follow-up. Andreas >> + * @bus: Bus to be reset. >> + * >> + * Reset @bus and perform a bus-level ("hard") reset of all devices c= onnected >> + * to it, including recursive processing of all buses below @bus itse= lf. A >> + * hard reset means that qbus_reset_all will reset all state of the d= evice. >=20 > qbus_reset_all()? >=20 >> + * For PCI devices, for example, this will include the base address r= egisters >=20 > #PCIDevice? >=20 >> + * or configuration space. >> + */ >> +void qbus_reset_all(BusState *bus); >=20 > Otherwise looks trivial and okay. >=20 > Andreas >=20 >> void qbus_reset_all_fn(void *opaque); >> =20 >> void qbus_free(BusState *bus); [snip] --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg