From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54550)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tu5PF-0003io-1s
	for qemu-devel@nongnu.org; Sat, 12 Jan 2013 13:02:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tu5PA-0007Bu-L2
	for qemu-devel@nongnu.org; Sat, 12 Jan 2013 13:02:08 -0500
Received: from cantor2.suse.de ([195.135.220.15]:51825 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tu5PA-0007BM-Dn
	for qemu-devel@nongnu.org; Sat, 12 Jan 2013 13:02:04 -0500
Message-ID: <50F1A518.1070800@suse.de>
Date: Sat, 12 Jan 2013 19:02:00 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1357334986-13941-1-git-send-email-hpoussin@reactos.org>
	<1357334986-13941-7-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1357334986-13941-7-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 06/10] acpi-piix4: do not use
 old_portio-style callbacks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org

Am 04.01.2013 22:29, schrieb Herv=C3=A9 Poussineau:
>  static const MemoryRegionOps piix4_pci_ops =3D {
> -    .old_portio =3D (MemoryRegionPortio[]) {
> -        {
> -            .offset =3D PCI_UP_BASE - PCI_HOTPLUG_ADDR,   .len =3D 4, =
.size =3D 4,
> -            .read =3D pci_up_read,
> -        },{
> -            .offset =3D PCI_DOWN_BASE - PCI_HOTPLUG_ADDR, .len =3D 4, =
.size =3D 4,
> -            .read =3D pci_down_read,
> -        },{
> -            .offset =3D PCI_EJ_BASE - PCI_HOTPLUG_ADDR,   .len =3D 4, =
.size =3D 4,
> -            .read =3D pci_features_read,
> -            .write =3D pciej_write,
> -        },{
> -            .offset =3D PCI_RMV_BASE - PCI_HOTPLUG_ADDR,  .len =3D 4, =
.size =3D 4,
> -            .read =3D pcirmv_read,
> -        },
> -        PORTIO_END_OF_LIST()
> +    .read =3D pci_read,
> +    .write =3D pci_write,
> +    .endianness =3D DEVICE_NATIVE_ENDIAN,
> +    .valid =3D {
> +        .min_access_size =3D 4,
> +        .max_access_size =3D 4,
>      },
> -    .endianness =3D DEVICE_LITTLE_ENDIAN,

Ugh, question: Why is this changing Little Endian to native?

Andreas

>  };
> =20
>  static int piix4_device_hotplug(DeviceState *qdev, PCIDevice *dev,

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg