From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] iio: fix Kconfig for max1363
Date: Sat, 12 Jan 2013 20:54:55 +0000 [thread overview]
Message-ID: <50F1CD9F.3030803@kernel.org> (raw)
In-Reply-To: <1357838990-32503-1-git-send-email-pmeerw@pmeerw.net>
On 01/10/2013 05:29 PM, Peter Meerwald wrote:
> ERROR: "iio_triggered_buffer_setup" [drivers/iio/adc/max1363.ko] undefined!
> ERROR: "iio_triggered_buffer_cleanup" [drivers/iio/adc/max1363.ko] undefined!
>
> add select IIO_TRIGGERED_BUFFER
>
> IIO_TRIGGERED_BUFFER in turn selects IIO_TRIGGER and IIO_KFIFO_BUF, so drop those
> MAX1363_RING_BUFFER is not used anymore
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
Thanks,
Have added a reported by tag for Fengguang Wu and added to togreg branch of
iio.git
> ---
> drivers/iio/adc/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index fe822a1..e372257 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -100,10 +100,8 @@ config LP8788_ADC
> config MAX1363
> tristate "Maxim max1363 ADC driver"
> depends on I2C
> - select IIO_TRIGGER
> - select MAX1363_RING_BUFFER
> select IIO_BUFFER
> - select IIO_KFIFO_BUF
> + select IIO_TRIGGERED_BUFFER
> help
> Say yes here to build support for many Maxim i2c analog to digital
> converters (ADC). (max1361, max1362, max1363, max1364, max1036,
>
prev parent reply other threads:[~2013-01-12 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130110101642.GA18411@localhost>
2013-01-10 17:29 ` [PATCH] iio: fix Kconfig for max1363 Peter Meerwald
2013-01-12 20:54 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F1CD9F.3030803@kernel.org \
--to=jic23@kernel.org \
--cc=fengguang.wu@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.