From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756112Ab3AMUGJ (ORCPT ); Sun, 13 Jan 2013 15:06:09 -0500 Received: from smtp.multi.fi ([85.134.37.151]:44082 "EHLO smtp.multi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756029Ab3AMUGI (ORCPT ); Sun, 13 Jan 2013 15:06:08 -0500 Message-ID: <50F313A5.3020707@mageia.org> Date: Sun, 13 Jan 2013 22:05:57 +0200 From: Thomas Backlund User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org, libvirt-list@redhat.com Subject: Re: if_bridge.h: include in6.h for struct in6_addr use References: <50F2FF1B.3020708@mageia.org> In-Reply-To: <50F2FF1B.3020708@mageia.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas Backlund skrev 13.1.2013 20:38: > patch both inline and attached as thunderbird tends to mess up ... > ----- > > if_bridge.h uses struct in6_addr ip6; but does not include the in6.h > header. > > Found by trying to build libvirt and connman against 3.8-rc3 headers. > Ok, ignore this patch, it's not the correct fix as it introduces redefinitions... Btw, the error that I hit that made me suggest this fix was libvirt config check bailing out: config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has incomplete type > Reported-by: Colin Guthrie > Reported-by: Christiaan Welvaart > Signed-off-by: Thomas Backlund > > -- > > diff -Nurp linux-3.8-rc3/include/uapi/linux/if_bridge.h > linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h > --- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13 > 20:09:54.257271755 +0200 > +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13 > 20:15:04.153676151 +0200 > @@ -14,6 +14,7 @@ > #define _UAPI_LINUX_IF_BRIDGE_H > > #include > +#include > > #define SYSFS_BRIDGE_ATTR "bridge" > #define SYSFS_BRIDGE_FDB "brforward" > > > ----- > Thomas > -- Thomas