From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] I2C: S3C24X0: Resolve build error for VCMA9
Date: Mon, 14 Jan 2013 14:24:06 +0900 [thread overview]
Message-ID: <50F39676.3050909@samsung.com> (raw)
In-Reply-To: <1358140664-23237-1-git-send-email-rajeshwari.s@samsung.com>
On 14/01/13 14:17, Rajeshwari Shinde wrote:
> This patch resolves the build error for I2C driver in
> VCMA9.
what about errors?
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
> drivers/i2c/s3c24x0_i2c.c | 4 +++-
> drivers/i2c/s3c24x0_i2c.h | 3 ++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
> index 7ec01ec..769a2ba 100644
> --- a/drivers/i2c/s3c24x0_i2c.c
> +++ b/drivers/i2c/s3c24x0_i2c.c
> @@ -67,9 +67,11 @@
> * variables to live in SRAM
> */
> static unsigned int g_current_bus __attribute__((section(".data")));
> +#ifdef CONFIG_OF_CONTROL
> +static int i2c_busses __attribute__((section(".data")));
> static struct s3c24x0_i2c_bus i2c_bus[CONFIG_MAX_I2C_NUM]
> __attribute__((section(".data")));
> -static int i2c_busses __attribute__((section(".data")));
> +#endif
>
> #if !(defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5)
> static int GetI2CSDA(void)
> diff --git a/drivers/i2c/s3c24x0_i2c.h b/drivers/i2c/s3c24x0_i2c.h
> index 1243bf1..c75bcab 100644
> --- a/drivers/i2c/s3c24x0_i2c.h
> +++ b/drivers/i2c/s3c24x0_i2c.h
> @@ -31,11 +31,12 @@ struct s3c24x0_i2c {
> u32 iiclc;
> };
>
> +#ifdef CONFIG_OF_CONTROL
> struct s3c24x0_i2c_bus {
> int node; /* device tree node */
> int bus_num; /* i2c bus number */
> struct s3c24x0_i2c *regs;
> enum periph_id id;
I think int is suitable more than enum.
Currently periph_id is exynos specific.
> };
> -
> +#endif
> #endif /* _S3C24X0_I2C_H */
>
Thanks.
Minkyu Kang.
prev parent reply other threads:[~2013-01-14 5:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 5:17 [U-Boot] [PATCH] I2C: S3C24X0: Resolve build error for VCMA9 Rajeshwari Shinde
2013-01-14 5:24 ` Minkyu Kang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F39676.3050909@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.