Re: [PATCH v2] multipath: add detect_prio option to autodetect prioitizer

[Hannes Reinecke <hare@suse.de>]

On 01/12/2013 01:26 PM, Christophe Varoqui wrote:
> On ven., 2013-01-11 at 08:17 +0100, Hannes Reinecke wrote:
>> On 01/10/2013 09:13 PM, Benjamin Marzinski wrote:
>>> This patch adds a new multipath.conf option, detect_prio.  If set to yes,
>>> multipathd will try to determine the correct prioritizer for the device. If
>>> it finds one, that will be used instead of its configured prioritizer.  If
>>> none is found, the configured prioritizer will be used.  It can currently
>>> only detect ALUA devices.
>>>
>>> Also fixed and issue with select_prio where in the devices section, it was
>>> passing in the prio name string instead of the prio args string to prio_get()
>>>
>>> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
>>
>> Good idea.
>>
> Don"t you think it would be fair to fallback to autodetection if no
> prioritizer is set, instead ? Admins would expect the values they care
> to set in the config file are honored.
>
It would, if we had autodetection for more (or, better, all) 
hardware handlers.
Shouldn't be too hard.

I'll give it a go at it once this patchset is merged.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)