From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Subject: Re: [PATCH] nouveau: add support for setting engine on nve0
Date: Mon, 14 Jan 2013 11:06:06 +0100
Message-ID: <50F3D88E.7050201@canonical.com>
References: <50F029E0.5070102@canonical.com> <1358141140.3690.2.camel@turiel>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from youngberry.canonical.com (youngberry.canonical.com
	[91.189.89.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3DE02E5F4E
	for <dri-devel@lists.freedesktop.org>;
	Mon, 14 Jan 2013 02:06:10 -0800 (PST)
In-Reply-To: <1358141140.3690.2.camel@turiel>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: bskeggs@redhat.com
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

Hey,

Op 14-01-13 06:25, Ben Skeggs schreef:
> On Fri, 2013-01-11 at 16:04 +0100, Maarten Lankhorst wrote:
>> When a specific engine is needed that's not GR, struct nve0_fifo should be used,
>> and the engine member should be used to select the engine.
>>
>> This will fail on kernels before 3.8, since no support for such engines has been added yet.
> This looks strikingly similar to the version of the patch I sent you
> ages back.  Was there something you noticed wrong with that version?
I think you forgot to send that patch to me, I remember you sending me the mesa changes,
but not the libdrm diff. :)
> I do need to re-check some things with that patch and make sure it'll
> work properly on both 32/64-bit (hint: sizeof(struct nve0_fifo) is the
> same as nvc0_fifo on 64-bit, due to padding...), and maintain compat
> with pre-3.8 kernels.
This should not be the case with the patch I wrote. Since I encapsulate the
original nvc0_fifo struct as base, the size should be different.
> I'll try and sort this out before the end of tomorrow.
>
> Ben.
>
Sure, np. Just wanted to see if I could get the mesa changes in before 9.1 branching off. :)

~Maarten