From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37315)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1TukLV-0007hz-Fn
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 08:45:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1TukLU-0000GY-BG
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 08:45:01 -0500
Message-ID: <50F40BD9.3060509@web.de>
Date: Mon, 14 Jan 2013 14:44:57 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <9fbe5d61cc42fdeab2ec1029e5fa736644f34898.1358064560.git.blauwirbel@gmail.com>
	<50F282AC.7030003@reactos.org>
In-Reply-To: <50F282AC.7030003@reactos.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] pc87312: avoid define conflict on mingw32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-ppc@nongnu.org, sw@weilnetz.de, =?ISO-8859-1?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>, qemu-devel@nongnu.org

Am 13.01.2013 10:47, schrieb Hervé Poussineau:
> Blue Swirl a écrit :
>> Mingw32 headers define FAR, causing this warning:
>> /src/qemu/hw/pc87312.c:38:0: warning: "FAR" redefined [enabled by
>> default]
>> In file included from
>> /usr/local/lib/gcc/i686-mingw32msvc/4.7.0/../../../../i686-mingw32msvc/include/windows.h:48:0,
>>
>>                  from /src/qemu/include/sysemu/os-win32.h:29,
>>                  from /src/qemu/include/qemu-common.h:46,
>>                  from /src/qemu/include/exec/ioport.h:27,
>>                  from /src/qemu/hw/isa.h:6,
>>                  from /src/qemu/hw/pc87312.h:28,
>>                  from /src/qemu/hw/pc87312.c:26:
>> /usr/local/lib/gcc/i686-mingw32msvc/4.7.0/../../../../i686-mingw32msvc/include/windef.h:34:0:
>> note: this is the location of the previous definition
>>
>> Avoid the warning by expanding the macros.
>>
>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>> ---
>>  hw/pc87312.c |   38 +++++++++++++++++---------------------
>>  1 files changed, 17 insertions(+), 21 deletions(-)
> 
> Acked-by: Hervé Poussineau <hpoussin@reactos.org>

Thanks, applied to prep-up:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep-up

Andreas