From: Rob Herring <robherring2@gmail.com>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Matt Porter <mporter@ti.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Russ Dill <Russ.Dill@ti.com>
Subject: Re: [PATCH] OF: Link platform device resources properly.
Date: Mon, 14 Jan 2013 08:57:13 -0600 [thread overview]
Message-ID: <50F41CC9.1000105@gmail.com> (raw)
In-Reply-To: <1357252284-5990-1-git-send-email-panto@antoniou-consulting.com>
On 01/03/2013 04:31 PM, Pantelis Antoniou wrote:
> The resources of the platform devices created by the OF core were
> not properly linked. Make sure that they are, so that we don't get
> any crashes when trying to remove the device.
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> drivers/of/device.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/of/device.c b/drivers/of/device.c
> index 4c74e4f..d75fcaf 100644
> --- a/drivers/of/device.c
> +++ b/drivers/of/device.c
> @@ -62,6 +62,9 @@ int of_device_add(struct platform_device *ofdev)
> if (!ofdev->dev.parent)
> set_dev_node(&ofdev->dev, of_node_to_nid(ofdev->dev.of_node));
>
> + /* make sure we add the resources to the appropriate lists */
> + platform_device_link_resources(ofdev);
> +
Submit this with the patch that adds this function or state the
dependency please.
Rob
> return device_add(&ofdev->dev);
> }
>
>
prev parent reply other threads:[~2013-01-14 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 22:31 [PATCH] OF: Link platform device resources properly Pantelis Antoniou
2013-01-03 22:31 ` Pantelis Antoniou
2013-01-14 14:57 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F41CC9.1000105@gmail.com \
--to=robherring2@gmail.com \
--cc=Russ.Dill@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@ti.com \
--cc=panto@antoniou-consulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.