Re: code coverage and teuthology

[Josh Durgin <josh.durgin@inktank.com>]

On 01/10/2013 03:07 PM, Loic Dachary wrote:
> Hi,
>
> I successfully run teuthology with the proposed 3node_rgw.yaml [1] and changing the flavor from basic to gcov [2]. I hoped to use cov-init.sh ( https://github.com/ceph/teuthology/blob/master/coverage/cov-init.sh ) and then coverage.sh but I can't figure out how to make it work.
>
> Hints would be most appreciated ;-)

Looking at how it's run automatically might help:

https://github.com/ceph/teuthology/blob/master/teuthology/coverage.py#L88

> [1] 3node_rgw.yaml
>
> check-locks: false
> interactive-on-error: true
> overrides:
>    ceph:
>      branch: master
>      fs: xfs

You should also add 'coverage: true' for the ceph task overrides.
This way daemons are killed with SIGTERM, and the atexit function
that outputs coverage information will run.

Then you don't need your patch changing the flavor either.
For each task X, the docstring for teuthology.task.X.task documents
example usage and extra options like this.

Josh

> roles:
> - - mon.a
>    - mon.c
>    - osd.0
> - - mon.b
>    - mds.a
>    - osd.1
> - - client.0
> tasks:
> - ceph: null
> - rgw:
>    - client.0
> - interactive:
>
> targets:
> (snip)
>
> [2] http://gitbuilder.ceph.com/ceph-tarball-precise-x86_64-gcov/
>
> diff --git a/teuthology/task/ceph.py b/teuthology/task/ceph.py
> index b62bc1d..99d4f18 100644
> --- a/teuthology/task/ceph.py
> +++ b/teuthology/task/ceph.py
> @@ -1027,7 +1027,7 @@ def task(ctx, config):
>       dist = 'precise'
>       format = 'tarball'
>       arch = 'x86_64'
> -    flavor = 'basic'
> +    flavor = 'gcov'
>
>       # First element: controlled by user (or not there, by default):
>       # used to choose the right distribution, e.g. "oneiric".
> diff --git a/teuthology/task/kernel.py b/teuthology/task/kernel.py
> index 5c34433..54eaebb 100644
> --- a/teuthology/task/kernel.py
> +++ b/teuthology/task/kernel.py
> @@ -183,7 +183,7 @@ def download_deb(ctx, config):
>                   package='kernel',
>                   sha1=src,
>                   format='deb',
> -                flavor='basic',
> +                flavor='gcov',
>                   arch='x86_64',
>                   dist='precise',
>                   )
> @@ -408,7 +408,7 @@ def task(ctx, config):
>                   branch=role_config.get('branch'),
>                   tag=role_config.get('tag'),
>                   sha1=role_config.get('sha1'),
> -                flavor='basic',
> +                flavor='gcov',
>                   format='deb',
>                   dist='precise',
>                   arch='x86_64',
>