From: Jeff Garzik <jgarzik@pobox.com>
To: y b <ycbzzjlby@gmail.com>
Cc: kernel@teksavvy.com, linux-ide@vger.kernel.org
Subject: Re: Fix ahci don't retry commands after a success error handler.
Date: Mon, 14 Jan 2013 13:10:01 -0500 [thread overview]
Message-ID: <50F449F9.6090703@pobox.com> (raw)
In-Reply-To: <CAPoh-nbV0yc_QH-D3L5ms_n_83BkPFC6ZUJHd=H9t=hqKRKVWw@mail.gmail.com>
On 01/06/2013 12:14 AM, y b wrote:
>>From 78c0fb104c9957db682518b97ce6a01ce1bc07b6 Mon Sep 17 00:00:00 2001
> From: Bian Yu <bianyu@kedacom.com>
> Date: Wed, 12 Dec 2012 22:26:58 -0500
> Subject: [PATCH] It should be a mistake introduced by commit 8d899e70c1b3afff.
> because only qc->flags can't be set AC_ERR_*
>
> Signed-off-by: Bian Yu <bianyu@kedacom.com>
> ---
> drivers/ata/libata-eh.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index bf039b0..bcf4437 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -2094,7 +2094,7 @@ static unsigned int ata_eh_speed_down(struct
> ata_device *dev,
> */
> static inline int ata_eh_worth_retry(struct ata_queued_cmd *qc)
> {
> - if (qc->flags & AC_ERR_MEDIA)
> + if (qc->err_mask & AC_ERR_MEDIA)
> return 0; /* don't retry media errors */
> if (qc->flags & ATA_QCFLAG_IO)
applied, good catch
prev parent reply other threads:[~2013-01-14 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 5:14 Fix ahci don't retry commands after a success error handler y b
2013-01-14 18:10 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F449F9.6090703@pobox.com \
--to=jgarzik@pobox.com \
--cc=kernel@teksavvy.com \
--cc=linux-ide@vger.kernel.org \
--cc=ycbzzjlby@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.