Re: [Qemu-devel] [PATCH v8 4/4] Add qemu-img compare documentation

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

On 01/14/2013 03:26 AM, Miroslav Rezanina wrote:
> Adding documentation for new qemu-img subcommand compare.
> 
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
>  qemu-img.c    |    7 ++++++-
>  qemu-img.texi |   32 ++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+), 1 deletions(-)

Your series is lacking a test case; it would be useful to test both
identical images, images that are identical only when not in strict
mode, and differing images.

> +Check if two images have the same content. You can compare images with
> +different format or settings.
> +
> +The format is probed unless you specify it by @var{-f} (used for @var{filename1}) and/or @var{-F} (used for @var{filename2}) option.

Long line; worth wrapping.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]