From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tushar Behera Subject: Re: [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock Date: Tue, 15 Jan 2013 09:01:49 +0530 Message-ID: <50F4CDA5.3090904@linaro.org> References: <003501cd9d65$9611d060$c2357120$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-da0-f54.google.com ([209.85.210.54]:40568 "EHLO mail-da0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699Ab3AODb5 (ORCPT ); Mon, 14 Jan 2013 22:31:57 -0500 Received: by mail-da0-f54.google.com with SMTP id n2so2073074dad.27 for ; Mon, 14 Jan 2013 19:31:56 -0800 (PST) In-Reply-To: <003501cd9d65$9611d060$c2357120$@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sangsu Park Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Sangbeom Kim On 09/28/2012 04:09 PM, Sangsu Park wrote: > Remove I2S0 clock from peril since peril doesn't have I2S0 clock for EXYNOS4. > Audio Subsystem block has I2S0 clk. > > Signed-off-by: sangsu > --- > arch/arm/mach-exynos/clock-exynos4.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/mach-exynos/clock-exynos4.c > b/arch/arm/mach-exynos/clock-exynos4.c > index 6a45c9a..fa8a134 100644 > --- a/arch/arm/mach-exynos/clock-exynos4.c > +++ b/arch/arm/mach-exynos/clock-exynos4.c > @@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = { > .ctrlbit = (1 << 18), > }, { > .name = "iis", > - .devname = "samsung-i2s.0", > - .enable = exynos4_clk_ip_peril_ctrl, > - .ctrlbit = (1 << 19), > - }, { > - .name = "iis", > .devname = "samsung-i2s.1", > .enable = exynos4_clk_ip_peril_ctrl, > .ctrlbit = (1 << 20), > After this clock has been removed, I2S0 registration fails on EXYNOS4 based boards (clk_get for iis clock fails). The alternate clock from Audio subsystem block is missing. -- Tushar Behera From mboxrd@z Thu Jan 1 00:00:00 1970 From: tushar.behera@linaro.org (Tushar Behera) Date: Tue, 15 Jan 2013 09:01:49 +0530 Subject: [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock In-Reply-To: <003501cd9d65$9611d060$c2357120$@samsung.com> References: <003501cd9d65$9611d060$c2357120$@samsung.com> Message-ID: <50F4CDA5.3090904@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/28/2012 04:09 PM, Sangsu Park wrote: > Remove I2S0 clock from peril since peril doesn't have I2S0 clock for EXYNOS4. > Audio Subsystem block has I2S0 clk. > > Signed-off-by: sangsu > --- > arch/arm/mach-exynos/clock-exynos4.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/mach-exynos/clock-exynos4.c > b/arch/arm/mach-exynos/clock-exynos4.c > index 6a45c9a..fa8a134 100644 > --- a/arch/arm/mach-exynos/clock-exynos4.c > +++ b/arch/arm/mach-exynos/clock-exynos4.c > @@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = { > .ctrlbit = (1 << 18), > }, { > .name = "iis", > - .devname = "samsung-i2s.0", > - .enable = exynos4_clk_ip_peril_ctrl, > - .ctrlbit = (1 << 19), > - }, { > - .name = "iis", > .devname = "samsung-i2s.1", > .enable = exynos4_clk_ip_peril_ctrl, > .ctrlbit = (1 << 20), > After this clock has been removed, I2S0 registration fails on EXYNOS4 based boards (clk_get for iis clock fails). The alternate clock from Audio subsystem block is missing. -- Tushar Behera