From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tuy5I-0000A4-GD
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 23:25:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tuy5G-0000Z5-6C
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 23:25:12 -0500
Received: from cantor2.suse.de ([195.135.220.15]:59206 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tuy5G-0000Yw-0P
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 23:25:10 -0500
Message-ID: <50F4DA20.3020803@suse.de>
Date: Tue, 15 Jan 2013 05:25:04 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1309ac93ff943931eb213dd87cd3570910b23926.1358094930.git.blauwirbel@gmail.com>
In-Reply-To: <1309ac93ff943931eb213dd87cd3570910b23926.1358094930.git.blauwirbel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] bswap: improve gluing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, rth@twiddle.net

Am 13.01.2013 17:35, schrieb Blue Swirl:
> OpenBSD system compiler (gcc 4.2.1) has problems with concatenation
> of macro arguments in macro functions:
>   CC    aes.o
> In file included from /src/qemu/include/qemu-common.h:126,
>                  from /src/qemu/aes.c:30:
> /src/qemu/include/qemu/bswap.h: In function 'leul_to_cpu':
> /src/qemu/include/qemu/bswap.h:461: warning: implicit declaration of fu=
nction 'bswapHOST_LONG_BITS'
> /src/qemu/include/qemu/bswap.h:461: warning: nested extern declaration =
of 'bswapHOST_LONG_BITS'
>=20
> Function leul_to_cpu() is only used in kvm-all.c, so the warnings
> are not fatal on OpenBSD without -Werror.
>=20
> Fix by applying glue(). Also add do {} while(0) wrapping and fix
> semicolon use while at it.
>=20
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

Tested-by: Andreas F=E4rber <afaerber@suse.de>

This unbreaks the build on openSUSE 12.2 ppc64:
gcc (SUSE Linux) 4.7.1 20120723 [gcc-4_7-branch revision 189773]

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg