From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuyXD-0005Jn-Ab for qemu-devel@nongnu.org; Mon, 14 Jan 2013 23:54:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuyXB-00084p-Ui for qemu-devel@nongnu.org; Mon, 14 Jan 2013 23:54:03 -0500 Received: from cantor2.suse.de ([195.135.220.15]:59916 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuyXB-00083V-Le for qemu-devel@nongnu.org; Mon, 14 Jan 2013 23:54:01 -0500 Message-ID: <50F4E0E4.8000506@suse.de> Date: Tue, 15 Jan 2013 05:53:56 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1357723028-12929-1-git-send-email-kraxel@redhat.com> <1357723028-12929-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1357723028-12929-2-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] pixman: fix warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Blue Swirl , qemu-devel@nongnu.org, agraf@suse.de Am 09.01.2013 10:17, schrieb Gerd Hoffmann: > Cc: afaerber@suse.de > Cc: agraf@suse.de > Signed-off-by: Gerd Hoffmann > --- > include/ui/qemu-pixman.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) >=20 > diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h > index 3c05c83..016fd87 100644 > --- a/include/ui/qemu-pixman.h > +++ b/include/ui/qemu-pixman.h > @@ -6,7 +6,14 @@ > #ifndef QEMU_PIXMAN_H > #define QEMU_PIXMAN_H > =20 > +/* pixman-0.16.0 headers have a redundant declaration */ > +#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE > +#pragma GCC diagnostic ignored "-Wredundant-decls" > +#endif > #include > +#ifdef CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE > +#pragma GCC diagnostic error "-Wredundant-decls" > +#endif > =20 > #include "console.h" > =20 Unfortunately this did not help on SLES11 SP2. I don't spot any typo in your patches, it looked neat; CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE does not get defined in config-host.h it seems. Using the pragmas unconditionally results in change from: CC qemu-timer.o cc1: warnings being treated as errors In file included from /home/andreas/QEMU/qemu-s390/include/ui/qemu-pixman.h:13, from /home/andreas/QEMU/qemu-s390/include/ui/console.h:4= , from /home/andreas/QEMU/qemu-s390/qemu-timer.c:27: /usr/include/pixman-1/pixman.h:225: error: redundant redeclaration of =E2=80=98pixman_transform_from_pixman_f_transform=E2=80=99 /usr/include/pixman-1/pixman.h:221: error: previous declaration of =E2=80=98pixman_transform_from_pixman_f_transform=E2=80=99 was here make: *** [qemu-timer.o] Fehler 1 to: CC qemu-timer.o cc1: warnings being treated as errors In file included from /home/andreas/QEMU/qemu-s390/include/ui/qemu-pixman.h:13, from /home/andreas/QEMU/qemu-s390/include/ui/console.h:4= , from /home/andreas/QEMU/qemu-s390/qemu-timer.c:27: /usr/include/pixman-1/pixman.h:221: error: previous declaration of =E2=80=98pixman_transform_from_pixman_f_transform=E2=80=99 was here make: *** [qemu-timer.o] Fehler 1 gcc (SUSE Linux) 4.3.4 [gcc-4_3-branch revision 152973] Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg