From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up Date: Tue, 15 Jan 2013 13:56:19 +0100 Message-ID: <50F551F3.2060400@linaro.org> References: <1357318799-24378-1-git-send-email-daniel.lezcano@linaro.org> <1357318799-24378-5-git-send-email-daniel.lezcano@linaro.org> <50EF3369.2060902@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-oa0-f42.google.com ([209.85.219.42]:53269 "EHLO mail-oa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636Ab3AOM4U (ORCPT ); Tue, 15 Jan 2013 07:56:20 -0500 Received: by mail-oa0-f42.google.com with SMTP id j1so57203oag.15 for ; Tue, 15 Jan 2013 04:56:20 -0800 (PST) In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: kgene.kim@samsung.com Cc: amit daniel kachhap , linux-samsung-soc@vger.kernel.org, linaro-dev@lists.linaro.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org On 01/10/2013 11:33 PM, amit daniel kachhap wrote: > On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano wrote: >> On 01/10/2013 09:07 PM, amit daniel kachhap wrote: >>> Hi Daniel, >> >> Hi Amit Daniel, >> >>> This hotplug noifiers looks fine. I suppose it should add extra sta= te >>> C1 in cpu0. If it is done like below than for normal cases(when all >>> cpu's are online) there wont be any statistics for C0 state >> >> I guess you meant state 0 which is WFI, right ? >> C0 state is the intel semantic for cpu fully turned on. > Yes I meant C0 as wfi >> >>> also which >>> is required. Other patches look good. >> >> Ok, that makes sense to have statistics even if they are only doing = WFI. >> >> Then the patch 4/5 is not ok, no ? > yes I suppose patch 4 and patch 5 are related and depends how you > frame patch 5. I think it is better to create C0/C1 sysfs and other > things in the beginning because it is a filesystem call and may > increase the cpu hotplug time which is not worth. May be if cpuidle > framework exposes some API to enable/disable states then it is better= =2E >=20 > For patch 1,2 and 3, > Acked-by: Amit Daniel Kachhap Hi Kukjin, is it possible to take these patches [1-3/5] ? The patches [3-4/5] could be ignored. Thanks -- Daniel --=20 Linaro.org =E2=94=82 Open source software for= ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Tue, 15 Jan 2013 13:56:19 +0100 Subject: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up In-Reply-To: References: <1357318799-24378-1-git-send-email-daniel.lezcano@linaro.org> <1357318799-24378-5-git-send-email-daniel.lezcano@linaro.org> <50EF3369.2060902@free.fr> Message-ID: <50F551F3.2060400@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/10/2013 11:33 PM, amit daniel kachhap wrote: > On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano wrote: >> On 01/10/2013 09:07 PM, amit daniel kachhap wrote: >>> Hi Daniel, >> >> Hi Amit Daniel, >> >>> This hotplug noifiers looks fine. I suppose it should add extra state >>> C1 in cpu0. If it is done like below than for normal cases(when all >>> cpu's are online) there wont be any statistics for C0 state >> >> I guess you meant state 0 which is WFI, right ? >> C0 state is the intel semantic for cpu fully turned on. > Yes I meant C0 as wfi >> >>> also which >>> is required. Other patches look good. >> >> Ok, that makes sense to have statistics even if they are only doing WFI. >> >> Then the patch 4/5 is not ok, no ? > yes I suppose patch 4 and patch 5 are related and depends how you > frame patch 5. I think it is better to create C0/C1 sysfs and other > things in the beginning because it is a filesystem call and may > increase the cpu hotplug time which is not worth. May be if cpuidle > framework exposes some API to enable/disable states then it is better. > > For patch 1,2 and 3, > Acked-by: Amit Daniel Kachhap Hi Kukjin, is it possible to take these patches [1-3/5] ? The patches [3-4/5] could be ignored. Thanks -- Daniel -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog