From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Tue, 15 Jan 2013 10:58:30 -0300 Subject: [PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board In-Reply-To: <201301151307.26665.arnd@arndb.de> References: <1358243670-11935-1-git-send-email-ezequiel.garcia@free-electrons.com> <1358243670-11935-2-git-send-email-ezequiel.garcia@free-electrons.com> <201301151307.26665.arnd@arndb.de> Message-ID: <50F56086.2040101@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, On 01/15/2013 10:07 AM, Arnd Bergmann wrote: > On Tuesday 15 January 2013, Ezequiel Garcia wrote: >> Cc: Lior Amsalem >> Cc: Thomas Petazzoni >> Cc: Gregory CLEMENT >> Signed-off-by: Ezequiel Garcia > > The patches look good, but when you have four trivial patches > doing the same thing in different files, and you decide that it's > not worth writing a changelog for them, they should probably > go into a single patch. > Mmm... maybe you're right and such splitting is excessive. It seemed tidier this way, enabling each board on a different patch. I can squash them on a v2, if you want me to. Thanks for reviewing! -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board Date: Tue, 15 Jan 2013 10:58:30 -0300 Message-ID: <50F56086.2040101@free-electrons.com> References: <1358243670-11935-1-git-send-email-ezequiel.garcia@free-electrons.com> <1358243670-11935-2-git-send-email-ezequiel.garcia@free-electrons.com> <201301151307.26665.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <201301151307.26665.arnd-r2nGTMty4D4@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Florian Fainelli , Andrew Lunn , Yehuda Yitschak , Lior Amsalem , Jason Cooper , Michael Opdenacker , Thomas Petazzoni , Gregory CLEMENT List-Id: devicetree@vger.kernel.org Hi Arnd, On 01/15/2013 10:07 AM, Arnd Bergmann wrote: > On Tuesday 15 January 2013, Ezequiel Garcia wrote: >> Cc: Lior Amsalem >> Cc: Thomas Petazzoni >> Cc: Gregory CLEMENT >> Signed-off-by: Ezequiel Garcia >=20 > The patches look good, but when you have four trivial patches > doing the same thing in different files, and you decide that it's > not worth writing a changelog for them, they should probably > go into a single patch. > Mmm... maybe you're right and such splitting is excessive. It seemed tidier this way, enabling each board on a different patch. I can squash them on a v2, if you want me to. Thanks for reviewing! --=20 Ezequiel Garc=EDa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html