From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv7mv-0004Xv-6P for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:46:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv7mu-00032e-5H for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:46:53 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56230 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv7mt-00032a-V6 for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:46:52 -0500 Message-ID: <50F56BD6.3020409@suse.de> Date: Tue, 15 Jan 2013 15:46:46 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1358242058-1404-1-git-send-email-afaerber@suse.de> <1358242058-1404-7-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: xen-devel , "qemu-devel@nongnu.org" Am 15.01.2013 12:03, schrieb Stefano Stabellini: > On Tue, 15 Jan 2013, Andreas F=C3=A4rber wrote: >> Use the global first_cpu variable to halt the CPU rather than using a >> local first_cpu initialized from qemu_get_cpu(0). >> >> This will allow to change qemu_get_cpu() return type to CPUState >> despite use of the CPU_COMMON halted field in the reset handler. >> >> Signed-off-by: Andreas F=C3=A4rber >=20 > Acked-by: Stefano Stabellini Thanks, but this is already in a pull... I did not see you on IRC shortly before I applied this as base for the x86 -cpu check/enforce patches, but we had talked about this change being okay before. Cheers, Andreas >> xen-all.c | 4 +--- >> 1 Datei ge=C3=A4ndert, 1 Zeile hinzugef=C3=BCgt(+), 3 Zeilen entfernt= (-) >> >> diff --git a/xen-all.c b/xen-all.c >> index 19bcfd1..110f958 100644 >> --- a/xen-all.c >> +++ b/xen-all.c >> @@ -585,9 +585,7 @@ static void xen_reset_vcpu(void *opaque) >> =20 >> void xen_vcpu_init(void) >> { >> - CPUArchState *first_cpu; >> - >> - if ((first_cpu =3D qemu_get_cpu(0))) { >> + if (first_cpu !=3D NULL) { >> qemu_register_reset(xen_reset_vcpu, first_cpu); >> xen_reset_vcpu(first_cpu); >> } >> --=20 >> 1.7.10.4 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [PATCH 06/20] xen: Simplify halting of first CPU Date: Tue, 15 Jan 2013 15:46:46 +0100 Message-ID: <50F56BD6.3020409@suse.de> References: <1358242058-1404-1-git-send-email-afaerber@suse.de> <1358242058-1404-7-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini Cc: xen-devel , "qemu-devel@nongnu.org" List-Id: xen-devel@lists.xenproject.org Am 15.01.2013 12:03, schrieb Stefano Stabellini: > On Tue, 15 Jan 2013, Andreas F=C3=A4rber wrote: >> Use the global first_cpu variable to halt the CPU rather than using a >> local first_cpu initialized from qemu_get_cpu(0). >> >> This will allow to change qemu_get_cpu() return type to CPUState >> despite use of the CPU_COMMON halted field in the reset handler. >> >> Signed-off-by: Andreas F=C3=A4rber >=20 > Acked-by: Stefano Stabellini Thanks, but this is already in a pull... I did not see you on IRC shortly before I applied this as base for the x86 -cpu check/enforce patches, but we had talked about this change being okay before. Cheers, Andreas >> xen-all.c | 4 +--- >> 1 Datei ge=C3=A4ndert, 1 Zeile hinzugef=C3=BCgt(+), 3 Zeilen entfernt= (-) >> >> diff --git a/xen-all.c b/xen-all.c >> index 19bcfd1..110f958 100644 >> --- a/xen-all.c >> +++ b/xen-all.c >> @@ -585,9 +585,7 @@ static void xen_reset_vcpu(void *opaque) >> =20 >> void xen_vcpu_init(void) >> { >> - CPUArchState *first_cpu; >> - >> - if ((first_cpu =3D qemu_get_cpu(0))) { >> + if (first_cpu !=3D NULL) { >> qemu_register_reset(xen_reset_vcpu, first_cpu); >> xen_reset_vcpu(first_cpu); >> } >> --=20 >> 1.7.10.4 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg