From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv8Ga-0002wD-MF for qemu-devel@nongnu.org; Tue, 15 Jan 2013 10:17:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv8GZ-0003nu-Jp for qemu-devel@nongnu.org; Tue, 15 Jan 2013 10:17:32 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:33173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv8GZ-0003nk-DE for qemu-devel@nongnu.org; Tue, 15 Jan 2013 10:17:31 -0500 Received: by mail-wi0-f179.google.com with SMTP id o1so220660wic.12 for ; Tue, 15 Jan 2013 07:17:30 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50F57307.5000408@redhat.com> Date: Tue, 15 Jan 2013 16:17:27 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1358256220-5460-1-git-send-email-armbru@redhat.com> <1358256220-5460-3-git-send-email-armbru@redhat.com> In-Reply-To: <1358256220-5460-3-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Il 15/01/2013 14:23, Markus Armbruster ha scritto: > Signed-off-by: Markus Armbruster > --- > hw/scsi-disk.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c > index f8d7ef3..96db9a7 100644 > --- a/hw/scsi-disk.c > +++ b/hw/scsi-disk.c > @@ -85,9 +85,7 @@ static void scsi_free_request(SCSIRequest *req) > { > SCSIDiskReq *r = DO_UPCAST(SCSIDiskReq, req, req); > > - if (r->iov.iov_base) { > - qemu_vfree(r->iov.iov_base); > - } > + qemu_vfree(r->iov.iov_base); > } > > /* Helper function for command completion with sense. */ > Acked-by: Paolo Bonzini