From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43581)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TvAPX-00039w-AS
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 12:34:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TvAPS-0003FH-LH
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 12:34:55 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:44898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TvAPS-0003DZ-EC
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 12:34:50 -0500
Message-ID: <50F59336.2060707@weilnetz.de>
Date: Tue, 15 Jan 2013 18:34:46 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1358239777-29911-2-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1358239777-29911-2-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] build: fix Win32 clean build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

Am 15.01.2013 09:49, schrieb Paolo Bonzini:
> The version.o file did not appear explicitly as a dependency, and
> this caused clean builds to fail.  Force its build by making the
> Makefile depend on version.o.
>
> (We cannot add it to libqemuutil.a, because it doesn't export any
> symbol and thus would not be pulled by the linker).
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 7622a4c..cfa2fa6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -153,6 +153,7 @@ version.o: $(SRC_PATH)/version.rc config-host.h
>  	$(call quiet-command,$(WINDRES) -I. -o $@ $<,"  RC    $(TARGET_DIR)$@")
>  
>  version-obj-$(CONFIG_WIN32) += version.o
> +Makefile: $(version-obj-y)
>  
>  ######################################################################
>  # Build libraries


Tested-by: Stefan Weil <sw@weilnetz.de>

Blue, Paolo's patch fixes a recently introduced build regression for MinGW.
Please apply it to git master.

I won't send a pull request because it is a build fix.

Paolo, your latest modifications added one more regression
because MinGW builds now compile files which are only needed
for user mode (= never for MinGW).util/envlist.c uses strtok_r
which is unavailable for MinGW, so we get a compiler warning,
but no linker error because it is unused.

Regards
Stefan