From: Saul Wold <sgw@linux.intel.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V4 2/3] connman-conf: configures connman in qemu machines
Date: Tue, 15 Jan 2013 12:24:55 -0800 [thread overview]
Message-ID: <50F5BB17.4040709@linux.intel.com> (raw)
In-Reply-To: <20130115202116.GB3002@jama>
On 01/15/2013 12:21 PM, Martin Jansa wrote:
> On Tue, Jan 15, 2013 at 10:08:46PM +0200, Cristian Iorga wrote:
>> For qemu machines, connman should not configure
>> virtual wired interfaces. Wired interfaces (eth0)
>> are assigned static IP addresses by the virtual machine
>> manager (qemu). This packages places the eth0 interface in
>> a list of blacklisted interfaces, forbiding connman
>> administering wired interfaces for qemu machines.
>
> Again wrong order,
>
> 3/3 should be 1st
> 2/3 2nd
> 1/3 3rd
>
I have re-ordered this in my consolidated pull MUT staging area, saw
that right away!
Sau!
> Cheers,
>
>>
>> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
>> ---
>> meta/conf/layer.conf | 1 +
>> meta/recipes-connectivity/connman/connman-conf.bb | 18 ++++++++++++++++++
>> .../connman/connman-conf/qemuall/main.conf | 3 +++
>> 3 files changed, 22 insertions(+)
>> create mode 100644 meta/recipes-connectivity/connman/connman-conf.bb
>> create mode 100644 meta/recipes-connectivity/connman/connman-conf/qemuall/main.conf
>>
>> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
>> index 78ceae9..3259e5c 100644
>> --- a/meta/conf/layer.conf
>> +++ b/meta/conf/layer.conf
>> @@ -22,6 +22,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \
>> shadow-securetty \
>> opkg-config-base \
>> netbase \
>> + connman-conf \
>> formfactor \
>> xserver-xf86-config \
>> pointercal \
>> diff --git a/meta/recipes-connectivity/connman/connman-conf.bb b/meta/recipes-connectivity/connman/connman-conf.bb
>> new file mode 100644
>> index 0000000..7c7ef26
>> --- /dev/null
>> +++ b/meta/recipes-connectivity/connman/connman-conf.bb
>> @@ -0,0 +1,18 @@
>> +#connman config to ignore wired interfaces on qemu machines
>> +
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
>> +
>> +SRC_URI_append_qemuall = " file://main.conf"
>> +
>> +PR = "r0"
>> +
>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>> +
>> +do_install() {
>> + #Blacklist ethn network interface in case of qemu* machines
>> + if test -e ${WORKDIR}/main.conf; then
>> + install -d ${D}${sysconfdir}/connman
>> + install -m 0644 ${WORKDIR}/main.conf ${D}${sysconfdir}/connman
>> + fi
>> +}
>> diff --git a/meta/recipes-connectivity/connman/connman-conf/qemuall/main.conf b/meta/recipes-connectivity/connman/connman-conf/qemuall/main.conf
>> new file mode 100644
>> index 0000000..01973e7
>> --- /dev/null
>> +++ b/meta/recipes-connectivity/connman/connman-conf/qemuall/main.conf
>> @@ -0,0 +1,3 @@
>> +[General]
>> +
>> +NetworkInterfaceBlacklist = eth
>> --
>> 1.7.10.4
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2013-01-15 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 20:08 [PATCH V4 0/3] connman 1.10 upgrade and qemu networking fix Cristian Iorga
2013-01-15 20:08 ` [PATCH V4 1/3] connman: upgrade to 1.10 Cristian Iorga
2013-01-15 20:08 ` [PATCH V4 2/3] connman-conf: configures connman in qemu machines Cristian Iorga
2013-01-15 20:15 ` Otavio Salvador
2013-01-15 20:18 ` Iorga, Cristian
2013-01-15 20:21 ` Martin Jansa
2013-01-15 20:24 ` Saul Wold [this message]
2013-01-29 20:02 ` Stanacar, StefanX
2013-01-15 20:08 ` [PATCH V4 3/3] qemu: machine override ability added Cristian Iorga
2013-01-16 7:42 ` [PATCH V4 0/3] connman 1.10 upgrade and qemu networking fix Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F5BB17.4040709@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.