From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Subject: Re: [BUG Fix Patch 1/6] Bug fix: Hold spinlock across find|remove /sys/firmware/memmap/X operation. Date: Wed, 16 Jan 2013 10:12:07 +0800 Message-ID: <50F60C77.9000201@cn.fujitsu.com> References: <1358247267-18089-1-git-send-email-tangchen@cn.fujitsu.com> <1358247267-18089-2-git-send-email-tangchen@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:47069 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1757252Ab3APCMx (ORCPT ); Tue, 15 Jan 2013 21:12:53 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Julian Calaby Cc: akpm@linux-foundation.org, rientjes@google.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, glommer@parallels.com, jiang.liu@huawei.com, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org On 01/16/2013 06:26 AM, Julian Calaby wrote: > Hi Tang, > > One minor point. > >> >> /* >> - * Search memmap entry >> + * firmware_map_find_entry: Search memmap entry. >> + * @start: Start of the memory range. >> + * @end: End of the memory range (exclusive). >> + * @type: Type of the memory range. >> + * >> + * This function is to find the memmap entey of a given memory range. >> + * The caller must hold map_entries_lock, and must not release the lock >> + * until the processing of the returned entry has completed. >> + * >> + * Return pointer to the entry to be found on success, or NULL on failure. > > Why not make this completely kernel-doc compliant as you're already > re-writing the comment? Hi Julian, Thank you for reminding me this. I think I may have some more problems like this. I'll post a patch to fix as many of them as I can. :) Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Date: Wed, 16 Jan 2013 02:12:07 +0000 Subject: Re: [BUG Fix Patch 1/6] Bug fix: Hold spinlock across find|remove /sys/firmware/memmap/X operation. Message-Id: <50F60C77.9000201@cn.fujitsu.com> List-Id: References: <1358247267-18089-1-git-send-email-tangchen@cn.fujitsu.com> <1358247267-18089-2-git-send-email-tangchen@cn.fujitsu.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julian Calaby Cc: akpm@linux-foundation.org, rientjes@google.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, glommer@parallels.com, jiang.liu@huawei.com, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org On 01/16/2013 06:26 AM, Julian Calaby wrote: > Hi Tang, > > One minor point. > >> >> /* >> - * Search memmap entry >> + * firmware_map_find_entry: Search memmap entry. >> + * @start: Start of the memory range. >> + * @end: End of the memory range (exclusive). >> + * @type: Type of the memory range. >> + * >> + * This function is to find the memmap entey of a given memory range. >> + * The caller must hold map_entries_lock, and must not release the lock >> + * until the processing of the returned entry has completed. >> + * >> + * Return pointer to the entry to be found on success, or NULL on failure. > > Why not make this completely kernel-doc compliant as you're already > re-writing the comment? Hi Julian, Thank you for reminding me this. I think I may have some more problems like this. I'll post a patch to fix as many of them as I can. :) Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from song.cn.fujitsu.com (unknown [222.73.24.84]) by ozlabs.org (Postfix) with ESMTP id 851442C009A for ; Wed, 16 Jan 2013 13:12:57 +1100 (EST) Message-ID: <50F60C77.9000201@cn.fujitsu.com> Date: Wed, 16 Jan 2013 10:12:07 +0800 From: Tang Chen MIME-Version: 1.0 To: Julian Calaby Subject: Re: [BUG Fix Patch 1/6] Bug fix: Hold spinlock across find|remove /sys/firmware/memmap/X operation. References: <1358247267-18089-1-git-send-email-tangchen@cn.fujitsu.com> <1358247267-18089-2-git-send-email-tangchen@cn.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, paulus@samba.org, hpa@zytor.com, sparclinux@vger.kernel.org, cl@linux.com, linux-s390@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, isimatu.yasuaki@jp.fujitsu.com, linfeng@cn.fujitsu.com, mgorman@suse.de, kosaki.motohiro@jp.fujitsu.com, rientjes@google.com, len.brown@intel.com, jiang.liu@huawei.com, wency@cn.fujitsu.com, cmetcalf@tilera.com, glommer@parallels.com, wujianguo@huawei.com, yinghai@kernel.org, laijs@cn.fujitsu.com, linux-kernel@vger.kernel.org, minchan.kim@gmail.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/16/2013 06:26 AM, Julian Calaby wrote: > Hi Tang, > > One minor point. > >> >> /* >> - * Search memmap entry >> + * firmware_map_find_entry: Search memmap entry. >> + * @start: Start of the memory range. >> + * @end: End of the memory range (exclusive). >> + * @type: Type of the memory range. >> + * >> + * This function is to find the memmap entey of a given memory range. >> + * The caller must hold map_entries_lock, and must not release the lock >> + * until the processing of the returned entry has completed. >> + * >> + * Return pointer to the entry to be found on success, or NULL on failure. > > Why not make this completely kernel-doc compliant as you're already > re-writing the comment? Hi Julian, Thank you for reminding me this. I think I may have some more problems like this. I'll post a patch to fix as many of them as I can. :) Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx159.postini.com [74.125.245.159]) by kanga.kvack.org (Postfix) with SMTP id F19AC6B0062 for ; Tue, 15 Jan 2013 21:12:52 -0500 (EST) Message-ID: <50F60C77.9000201@cn.fujitsu.com> Date: Wed, 16 Jan 2013 10:12:07 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [BUG Fix Patch 1/6] Bug fix: Hold spinlock across find|remove /sys/firmware/memmap/X operation. References: <1358247267-18089-1-git-send-email-tangchen@cn.fujitsu.com> <1358247267-18089-2-git-send-email-tangchen@cn.fujitsu.com> In-Reply-To: Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: owner-linux-mm@kvack.org List-ID: To: Julian Calaby Cc: akpm@linux-foundation.org, rientjes@google.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, glommer@parallels.com, jiang.liu@huawei.com, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org On 01/16/2013 06:26 AM, Julian Calaby wrote: > Hi Tang, > > One minor point. > >> >> /* >> - * Search memmap entry >> + * firmware_map_find_entry: Search memmap entry. >> + * @start: Start of the memory range. >> + * @end: End of the memory range (exclusive). >> + * @type: Type of the memory range. >> + * >> + * This function is to find the memmap entey of a given memory range. >> + * The caller must hold map_entries_lock, and must not release the lock >> + * until the processing of the returned entry has completed. >> + * >> + * Return pointer to the entry to be found on success, or NULL on failure. > > Why not make this completely kernel-doc compliant as you're already > re-writing the comment? Hi Julian, Thank you for reminding me this. I think I may have some more problems like this. I'll post a patch to fix as many of them as I can. :) Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org