From: Cong Wang <xiyou.wangcong@gmail.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC(v2) net-next 09/13] ipv6: Do not depend on rt->n in rt6_check_neigh().
Date: Wed, 16 Jan 2013 14:53:55 +0800 [thread overview]
Message-ID: <50F64E83.3000200@gmail.com> (raw)
In-Reply-To: <50F587D4.6060208@linux-ipv6.org>
On 01/16/2013 12:46 AM, YOSHIFUJI Hideaki wrote:
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> ---
> net/ipv6/route.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index e16a483..ffdc8a6 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -552,20 +552,25 @@ static inline bool rt6_check_neigh(struct rt6_info *rt)
> struct neighbour *neigh;
> bool ret = false;
>
> - neigh = rt->n;
> if (rt->rt6i_flags & RTF_NONEXTHOP ||
> - !(rt->rt6i_flags & RTF_GATEWAY))
> + !(rt->rt6i_flags & RTF_GATEWAY)) {
> ret = true;
> - else if (neigh) {
> - read_lock_bh(&neigh->lock);
> + goto out;
> + }
Just return true here...
prev parent reply other threads:[~2013-01-16 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 16:46 [RFC(v2) net-next 09/13] ipv6: Do not depend on rt->n in rt6_check_neigh() YOSHIFUJI Hideaki
2013-01-16 6:53 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F64E83.3000200@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.